Revert public API changes in #10931, preserve logic #11415
Merged
+435
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
revert-10931
branch
2 times, most recently
from
b0a127f to
3f595d9
Compare
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
revert-10931
branch
2 times, most recently
from
3544610 to
fa6ca74
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
force-pushed
the
revert-10931
branch
from
fa6ca74 to
58ab4b6
Compare
bogdandrutu
force-pushed
the
revert-10931
branch
6 times, most recently
from
dd0b7b1 to
de2d84f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11415 +/- ##
==========================================
- Coverage 91.64% 91.54% -0.10%
==========================================
Files 442 442
Lines 23746 23792 +46
==========================================
+ Hits 21761 21780 +19
- Misses 1616 1641 +25
- Partials 369 371 +2 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
revert-10931
branch
from
de2d84f to
786ff0f
Compare
|
@songy23 can you please review |
songy23
reviewed
Nov 14, 2024
|
Also it looks like this breaks the generated telemetry test in filter processor in contrib: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11841970416/job/33009752455?pr=11415 |
bogdandrutu
force-pushed
the
revert-10931
branch
from
786ff0f to
cf963b5
Compare
songy23
approved these changes
Nov 15, 2024
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
revert-10931
branch
from
cf963b5 to
829446c
Compare
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…en-telemetry#11415) This PR removes APIs that expose `configtelemetry.Level`. Internal functionality still uses the Level, but will be soon changed to use the new Instrument.Enabled. Signed-off-by: Bogdan Drutu <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…en-telemetry#11415) This PR removes APIs that expose `configtelemetry.Level`. Internal functionality still uses the Level, but will be soon changed to use the new Instrument.Enabled. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes APIs that expose
configtelemetry.Level. Internal functionality still uses the Level, but will be soon changed to use the new Instrument.Enabled.