[confmap] Support expansion for environment variables with time formats #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
Sep 23, 2024
|
You'll also need to create a change log entry for this as well with |
irisgve
force-pushed
the
support-time-envvar-expansion
branch
from
de250a6 to
d12a7b4
Compare
irisgve
force-pushed
the
support-time-envvar-expansion
branch
from
adec838 to
0b2af62
Compare
TylerHelmuth
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
I feel like adding the time.Time case to the error check is the proper way to handle this. @mx-psi do you agree?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11241 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 424 424
Lines 20222 20222
=======================================
Hits 18509 18509
Misses 1329 1329
Partials 384 384 ☔ View full report in Codecov by Sentry. |
|
Hey folks any chance this can get merged? 🙇🏻♀️ |
dmitryax
approved these changes
Sep 27, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…ts (open-telemetry#11241) #### Description This addresses open-telemetry#10659. In open-telemetry#10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in `provider.checkRawConfType()` This adds `time.Time` as a type in the `provider.checkRawConfType()` instead of removing it completely. #### Link to tracking issue Fixes open-telemetry#10659 <!--Describe what testing was performed and which tests were added.--> #### Testing - added a test case to handle time formats in provider.go and expand.go - added an e2e test case to handle time formats
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ts (open-telemetry#11241) #### Description This addresses open-telemetry#10659. In open-telemetry#10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in `provider.checkRawConfType()` This adds `time.Time` as a type in the `provider.checkRawConfType()` instead of removing it completely. #### Link to tracking issue Fixes open-telemetry#10659 <!--Describe what testing was performed and which tests were added.--> #### Testing - added a test case to handle time formats in provider.go and expand.go - added an e2e test case to handle time formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #10659. In #10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in
provider.checkRawConfType()This adds
time.Timeas a type in theprovider.checkRawConfType()instead of removing it completely.Link to tracking issue
Fixes #10659
Testing