-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Allow using any type as a string #10800
Merged
mx-psi
merged 2 commits into
open-telemetry:main
from
mx-psi:mx-psi/add-string-representation-for-everything
Aug 5, 2024
Merged
[confmap] Allow using any type as a string #10800
mx-psi
merged 2 commits into
open-telemetry:main
from
mx-psi:mx-psi/add-string-representation-for-everything
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/add-string-representation-for-everything
branch
from
August 5, 2024 11:37
de0305a
to
f667b9c
Compare
mx-psi
force-pushed
the
mx-psi/add-string-representation-for-everything
branch
from
August 5, 2024 11:39
f667b9c
to
9c94725
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10800 +/- ##
==========================================
+ Coverage 91.70% 91.71% +0.01%
==========================================
Files 406 406
Lines 18947 18947
==========================================
+ Hits 17376 17378 +2
+ Misses 1213 1209 -4
- Partials 358 360 +2 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Aug 5, 2024
dmitryax
approved these changes
Aug 5, 2024
dmitryax
pushed a commit
that referenced
this pull request
Sep 27, 2024
…ts (#11241) #### Description This addresses #10659. In #10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in `provider.checkRawConfType()` This adds `time.Time` as a type in the `provider.checkRawConfType()` instead of removing it completely. #### Link to tracking issue Fixes #10659 <!--Describe what testing was performed and which tests were added.--> #### Testing - added a test case to handle time formats in provider.go and expand.go - added an e2e test case to handle time formats
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…ts (open-telemetry#11241) #### Description This addresses open-telemetry#10659. In open-telemetry#10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in `provider.checkRawConfType()` This adds `time.Time` as a type in the `provider.checkRawConfType()` instead of removing it completely. #### Link to tracking issue Fixes open-telemetry#10659 <!--Describe what testing was performed and which tests were added.--> #### Testing - added a test case to handle time formats in provider.go and expand.go - added an e2e test case to handle time formats
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ts (open-telemetry#11241) #### Description This addresses open-telemetry#10659. In open-telemetry#10800 we removed restrictions on the types that can be allowed if expanded but in our case, this still fails because of the checks existing in `provider.checkRawConfType()` This adds `time.Time` as a type in the `provider.checkRawConfType()` instead of removing it completely. #### Link to tracking issue Fixes open-telemetry#10659 <!--Describe what testing was performed and which tests were added.--> #### Testing - added a test case to handle time formats in provider.go and expand.go - added an e2e test case to handle time formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows any type to be used as a string if the target field is a string or the value is expanded in inline position. Inspired by #10794. This is not a breaking change (previously we would return an error for these).
Some things that you can do after this PR that you couldn't do before it:
HOST
to[2001:db8::8a2e:370:7334]
and use it in an endpoint:Pass really big numbers as strings (e.g.
10000000000000000000
)Pass
null
as a string.Types that can be returned by our current YAML parser
Our current way of using the YAML parser has these types:
string
,nil
,int
,uint64
,float64
,map[any]any
,map[string]any
,[]any
.There is no documentation for this, but the following fuzzing test did not find any failing cases after 20 minutes of continous run: