Migrate ocb binary release to opentelemetry-collector-releases (see corresponding PR#608 in opentelemetry-collector-releases repo) #10710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgopack4
commented
Jul 23, 2024
jackgopack4
commented
Jul 23, 2024
jackgopack4
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10710 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 406 406
Lines 18950 18947 -3
=======================================
- Hits 17380 17378 -2
+ Misses 1210 1209 -1
Partials 360 360 ☔ View full report in Codecov by Sentry. |
jackgopack4
commented
Jul 24, 2024
jackgopack4
force-pushed
the
main
branch
2 times, most recently
from
625c3a6 to
ed2ff9e
Compare
|
rebased on upstream main following v0.106.0 release |
jackgopack4
changed the title
jackgopack4
force-pushed
the
main
branch
2 times, most recently
from
493a3ad to
0c3b8f6
Compare
jackgopack4
commented
Aug 1, 2024
jackgopack4
added a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Aug 1, 2024
evan-bradley
reviewed
Aug 2, 2024
mx-psi
approved these changes
Aug 6, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
evan-bradley
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Thanks for your continued work @jackgopack4. I'm overall good with this, though I did leave a comment about how we should approach tagging.
I think we should aim to merge the -releases PR before this one just to be safe. If we don't have both make it into the release, I think it would be better to double publish the release than to not publish one.
evan-bradley
approved these changes
Aug 6, 2024
dmitryax
approved these changes
Aug 9, 2024
6 tasks
andrzej-stencel
added a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
Sep 24, 2024
The location of builder binary releases has changed since v0.107.0. https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3 > `ocb`: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (open-telemetry#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"
bogdandrutu
pushed a commit
that referenced
this pull request
Sep 24, 2024
The location of builder binary releases has changed since v0.107.0. https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3 > `ocb`: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
The location of builder binary releases has changed since v0.107.0. https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3 > `ocb`: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (open-telemetry#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
The location of builder binary releases has changed since v0.107.0. https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3 > `ocb`: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (open-telemetry#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: After discussion with the collector SIG call this week, July 31st, I have made small tweaks to the artifact release that will not require an "extra step" of pushing tags. If these changes are accepted, the distributions will be released under tag "vX.XXX.X" and the ocb binaries will be released under "cmd/builder/vX.XXX.X" but both under this repo, opentelemetry-collector-releases. The workflow
builder-release.yamlin releases repo will push the additional tags necessary for the builder release.Refactoring the release process as mentioned in past issues/PRs. ocb binary is currently released in a separate release tag under this repository, which makes it harder to find and inconsistent with the rest of the binaries and images releasing in the opentelemetry-collector-releases repository.
Releasing the ocb binaries in opentelemetry-collector-releases makes this process more standardized and also opens the opportunity to release more tools alongside ocb binary down the road, like corresponding docker images (as discussed in #5712).
Link to tracking issue
Fixes #10662
Mentioned in releases issue # 295
Corresponding PR in opentelemetry-collector-releases
Testing
Sample binary release in forked jackgopack4/opentelemetry-collector-releases repo
Documentation
Updated corresponding documentation to reflect new release process