Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocb Docker image #5712

Closed
mx-psi opened this issue Jul 20, 2022 · 9 comments · Fixed by #11234
Closed

Add ocb Docker image #5712

mx-psi opened this issue Jul 20, 2022 · 9 comments · Fixed by #11234
Assignees
@sakshi1215
Labels
area:builder enhancement New feature or request

Comments

@mx-psi
Copy link
Member

mx-psi commented Jul 20, 2022

Is your feature request related to a problem? Please describe.

Per open-telemetry/opentelemetry-collector-releases/pull/164, we want to promote usage of the OpenTelemetry Collector Builder so that people build their own distribution with only the components they use.

We currently only provide the binaries on each release (example), but we don't have a Docker image for this, which would ease the use of the builder.

Describe the solution you'd like

Provider a Docker image for the builder.

Describe alternatives you've considered

Do nothing, if we consider this is not going to get usage.
@mx-psi mx-psi added enhancement New feature or request area:builder labels Jul 20, 2022
@mx-psi mx-psi mentioned this issue Jul 20, 2022
Merged
@sakshi1215
Copy link
Contributor

@dmitryax @jpkrohling As far as I could understand, we want to create a Dockerfile & release docker images for the collector builder, can I work on this if this is still relevant?

@jpkrohling
Copy link
Member

Sure, I think it would be worth the exercise. I'm not convinced this would work seamlessly for some Linux distributions (like Fedora), as selinux would prevent containers from writing to the host's file system, but I might be wrong.

@sakshi1215 sakshi1215 mentioned this issue Nov 1, 2022
Closed
@frzifus
Copy link
Member

frzifus commented Feb 15, 2023

@jpkrohling that should work using the z or Z mount option like here:
open-telemetry/opentelemetry-go-build-tools#222

@frzifus frzifus mentioned this issue Feb 16, 2023
Open
@jackgopack4
Copy link
Contributor

jackgopack4 commented Jul 15, 2024 •
edited
Loading

I see that we have docker images for the official releases, but I'm thinking it might still be useful to have docker images for custom builds.
It seems like there's no way to build a custom collector using the releases distributions Dockerfiles besides the default contrib, k8s, or core configuration. I might be wrong, as I am still trying to dig more into this process.

This was referenced Jul 18, 2024
Closed
Merged
dmitryax pushed a commit that referenced this issue Aug 9, 2024
@jackgopack4 @mx-psi
Migrate ocb binary release to opentelemetry-collector-releases (#10710)
8abfa02 
After discussion with the collector SIG call this week, July
31st, I have made small tweaks to the artifact release that will not
require an "extra step" of pushing tags. If these changes are accepted,
the distributions will be released under tag "vX.XXX.X" and the ocb
binaries will be released under "cmd/builder/vX.XXX.X" but both under
this repo, opentelemetry-collector-releases. The workflow
`builder-release.yaml` in releases repo will push the additional tags
necessary for the builder release.

Refactoring the release process as mentioned in past issues/PRs. ocb
binary is currently released in a separate release tag under this
repository, which makes it harder to find and inconsistent with the rest
of the binaries and images releasing in the
opentelemetry-collector-releases repository.

Releasing the ocb binaries in opentelemetry-collector-releases makes
this process more standardized and also opens the opportunity to release
more tools alongside ocb binary down the road, like corresponding docker
images (as discussed in #5712).

#### Link to tracking issue
Fixes #10662
Mentioned in [releases issue #
295](open-telemetry/opentelemetry-collector-releases#295)
[Corresponding PR in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#608)

#### Testing
Sample binary release in [forked
jackgopack4/opentelemetry-collector-releases
repo](https://github.com/jackgopack4/opentelemetry-collector-releases/releases/tag/cmd%2Fbuilder%2Fv0.106.1)

#### Documentation
Updated corresponding documentation to reflect new release process

---------

Co-authored-by: Pablo Baeyens <[email protected]>
@jackgopack4
Copy link
Contributor

Hi there, i'd like to create another repository under the "otel" organization on DockerHub, I believe it could be called "otel/opentelemetry-collector-builder" or "otel/ocb"; who has the ability to create this? thanks.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 17, 2024

@jackgopack4 I'd guess this would be done through an issue in the community repository but we should discuss what name we want first.

This was referenced Sep 18, 2024
Closed
Merged
Merged
@jackgopack4
Copy link
Contributor

PRs are up:
open-telemetry/opentelemetry-collector-releases#671
#11234
Will appreciate reviews on either or both! I'm still working on a blurb for opentelemetry.io as well under "building a custom collector" but will likely get to it Monday

@jackgopack4
Copy link
Contributor

Hi there, until open-telemetry/opentelemetry-collector-releases#671 is merged into releases, I think this issue should still stay open

@mx-psi mx-psi reopened this Oct 7, 2024
jackgopack4 added a commit to jackgopack4/opentelemetry-collector that referenced this issue Oct 8, 2024
@jackgopack4 @andrzej-stencel @songy23
update cmd/builder documentation for docker image (open-telemetry#11234)
6f596ce 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding documentation for corresponding [PR open-telemetry#671 in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671)

<!-- Issue number if applicable -->
#### Link to tracking issue
Closes open-telemetry#5712 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Github Actions and releases in personal fork,
github.com/jackgopack4/opentelemetry-collector-releases

<!--Describe the documentation added.-->
#### Documentation
updates to cmd/builder/README.md for OCB instructions and
docs/release.md for an automation that I also added in the releases PR
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <[email protected]>
Co-authored-by: Yang Song <[email protected]>
@jackgopack4 jackgopack4 mentioned this issue Oct 17, 2024
Merged
mx-psi pushed a commit that referenced this issue Oct 21, 2024
@jackgopack4 @github-actions
[chore] update cmd/builder documentation for docker image release (#1…
035fa2b 
…1480)

since
open-telemetry/opentelemetry-collector-releases#671
was merged into releases repository, docker images will be published
starting with ocb version 0.112.0

This reverts commit 8c4cfe5.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
update documentation for cmd/builder to include docker release
information
<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to
#5712
Documentation for
open-telemetry/opentelemetry-collector-releases#671

<!--Describe what testing was performed and which tests were added.-->
#### Testing
n/a
<!--Describe the documentation added.-->
#### Documentation
README.md and release.md
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mx-psi
Copy link
Member Author

mx-psi commented Oct 23, 2024

Fixed by open-telemetry/opentelemetry-collector-releases/pull/671

@mx-psi mx-psi closed this as completed Oct 23, 2024
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this issue Nov 21, 2024
@jackgopack4 @github-actions @djaglowski
[chore] update cmd/builder documentation for docker image release (op…
5a6f29b 
…en-telemetry#11480)

since
open-telemetry/opentelemetry-collector-releases#671
was merged into releases repository, docker images will be published
starting with ocb version 0.112.0

This reverts commit 8c4cfe5.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
update documentation for cmd/builder to include docker release
information
<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to
open-telemetry#5712
Documentation for
open-telemetry/opentelemetry-collector-releases#671

<!--Describe what testing was performed and which tests were added.-->
#### Testing
n/a
<!--Describe the documentation added.-->
#### Documentation
README.md and release.md
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@jackgopack4 @andrzej-stencel
@songy23 @HongChenTW
update cmd/builder documentation for docker image (open-telemetry#11234)
9676b38 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding documentation for corresponding [PR open-telemetry#671 in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671)

<!-- Issue number if applicable -->
#### Link to tracking issue
Closes open-telemetry#5712 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Github Actions and releases in personal fork,
github.com/jackgopack4/opentelemetry-collector-releases

<!--Describe the documentation added.-->
#### Documentation
updates to cmd/builder/README.md for OCB instructions and
docs/release.md for an automation that I also added in the releases PR
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <[email protected]>
Co-authored-by: Yang Song <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@jackgopack4 @github-actions @HongChenTW
[chore] update cmd/builder documentation for docker image release (op…
9a6807c 
…en-telemetry#11480)

since
open-telemetry/opentelemetry-collector-releases#671
was merged into releases repository, docker images will be published
starting with ocb version 0.112.0

This reverts commit 8c4cfe5.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
update documentation for cmd/builder to include docker release
information
<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to
open-telemetry#5712
Documentation for
open-telemetry/opentelemetry-collector-releases#671

<!--Describe what testing was performed and which tests were added.-->
#### Testing
n/a
<!--Describe the documentation added.-->
#### Documentation
README.md and release.md
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakshi1215 sakshi1215

Labels
area:builder enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@jpkrohling @mx-psi @jackgopack4 @frzifus @sakshi1215