-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiles support in connector #10703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
connector-profiles
branch
2 times, most recently
from
July 23, 2024 14:40
4353516
to
373f608
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10703 +/- ##
==========================================
- Coverage 92.07% 91.70% -0.37%
==========================================
Files 405 406 +1
Lines 18862 18953 +91
==========================================
+ Hits 17367 17381 +14
- Misses 1135 1212 +77
Partials 360 360 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
connector-profiles
branch
from
July 23, 2024 17:30
7ff499f
to
e7654bc
Compare
mx-psi
approved these changes
Jul 31, 2024
@dmathieu Can you fix the conflict? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows #10524 and adds profiles support into connectors.
Link to tracking issue
See #10375