Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles support in connector #10703

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 23, 2024

Description

This follows #10524 and adds profiles support into connectors.

Link to tracking issue

See #10375

@dmathieu dmathieu force-pushed the connector-profiles branch 2 times, most recently from 4353516 to 373f608 Compare July 23, 2024 14:40
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 77 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (6d32c09) to head (0c0e4d3).

Files Patch % Lines
connector/internal/factory.go 0.00% 77 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10703      +/-   ##
==========================================
- Coverage   92.07%   91.70%   -0.37%     
==========================================
  Files         405      406       +1     
  Lines       18862    18953      +91     
==========================================
+ Hits        17367    17381      +14     
- Misses       1135     1212      +77     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the connector-profiles branch from 7ff499f to e7654bc Compare July 23, 2024 17:30
@dmathieu dmathieu marked this pull request as ready for review July 23, 2024 18:07
@dmathieu dmathieu requested review from a team and evan-bradley July 23, 2024 18:07
@mx-psi mx-psi added this to the Profiling support milestone Jul 24, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 31, 2024

@dmathieu Can you fix the conflict?

@dmathieu
Copy link
Member Author

Done!

@mx-psi mx-psi merged commit c0188e0 into open-telemetry:main Jul 31, 2024
49 of 50 checks passed
@dmathieu dmathieu deleted the connector-profiles branch August 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants