Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connector into internal package, in preparation for profiles #10524

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 3, 2024

Description

This splits the connector package, so the APIs are in an internal package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.

Link to tracking issue

See #10375

cc @mx-psi

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 99.57447% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (6fcebdb) to head (aafe5b4).
Report is 1 commits behind head on main.

Files Patch % Lines
connector/internal/factory.go 99.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10524   +/-   ##
=======================================
  Coverage   92.26%   92.27%           
=======================================
  Files         395      397    +2     
  Lines       18703    18723   +20     
=======================================
+ Hits        17257    17277   +20     
  Misses       1086     1086           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the connector-internal branch from d171b2c to a022902 Compare July 3, 2024 08:00
@dmathieu
Copy link
Member Author

dmathieu commented Jul 3, 2024

This technically doesn't change any public API. So I suppose it doesn't need a changelog entry.

@dmathieu dmathieu marked this pull request as ready for review July 3, 2024 08:26
@dmathieu dmathieu requested review from a team and evan-bradley July 3, 2024 08:26
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 10, 2024
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all pass and the organization looks good to me.

connector/connector.go Outdated Show resolved Hide resolved
connector/builder.go Outdated Show resolved Hide resolved
@codeboten codeboten merged commit c270bef into open-telemetry:main Jul 15, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 15, 2024
@dmathieu dmathieu deleted the connector-internal branch July 16, 2024 07:04
@mx-psi mx-psi modified the milestones: v0.105.0, Profiling support Jul 23, 2024
mx-psi pushed a commit that referenced this pull request Jul 31, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This follows
#10524 and
adds profiles support into connectors.

<!-- Issue number if applicable -->
#### Link to tracking issue
See #10375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants