-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move connector into internal package, in preparation for profiles #10524
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10524 +/- ##
=======================================
Coverage 92.26% 92.27%
=======================================
Files 395 397 +2
Lines 18703 18723 +20
=======================================
+ Hits 17257 17277 +20
Misses 1086 1086
Partials 360 360 ☔ View full report in Codecov by Sentry. |
d171b2c
to
a022902
Compare
This technically doesn't change any public API. So I suppose it doesn't need a changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all pass and the organization looks good to me.
Description
This splits the connector package, so the APIs are in an internal package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.
Link to tracking issue
See #10375
cc @mx-psi