[chore] Reduce complexity in processorhelper obsreport #10693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
recordData
method, which I believe is an unhelpful abstraction for reporting internal processor metrics.The drawbacks of the function are minor, but briefly:
recordData
for all metrics. It's also fragile because if we have more than a few metrics it is easy to position the intended metric incorrectly.recordData
but then just used as a switch to get back to code that is specific to that data type.recordData
instantiates N variables, where N is the number of metrics for each data type.All of this seems unnecessary as we can just report each metric in one unambiguous line of code.