Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal processorhelper metrics are not reported until they have any non-zero values #10855

Closed
dmitryax opened this issue Aug 12, 2024 · 0 comments · Fixed by #10857
Closed
Labels
area:processor bug Something isn't working

Comments

@dmitryax
Copy link
Member

After #10693, the processor helper only reports metrics if they got any values other than 0. This is a significant change in the behavior compared to previous versions when we had all of them reported at once. We should document this in the changelog.

As a user, I would always prefer seeing 0 data points reported for any data sent through a processor for otelcol_processor_dropped_spans and otelcol_processor_refused_spans metrics. Happy to hear what other folks think though.

@dmitryax dmitryax added bug Something isn't working area:processor labels Aug 12, 2024
dmitryax added a commit that referenced this issue Aug 12, 2024
)

This change reverts
#10693,
which had an unintentional behavior change that made the processor
helper report metrics only if they got values other than `0`.

Fixes
#10855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:processor bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant