-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate component.Host.GetExporters #7370
Comments
I support this, if there are no objections, should we create issues on contrib for the individual components that need some work? |
@mx-psi, I've created tracking issues in contrib and updated my proposal to include them in a checklist. In my opinion, we are better off deprecating the function sooner rather than later. This will prevent new usages and give any external users as much notification as possible. I will also create a PR for this, but of course this can be merged if/when more approvers support it. |
I agree on the depreciation. We need to make sure all the contrib dependencies are resolved, should be ok to do that after the depreciation, but before the removal. |
From Datadog's side, the datadog processor was removed on v0.94.0. I am also proposing we remove the spanmetrics processor later this month. |
We discussed a way to speed this up that we can tackle as a last resort: we could remove the |
**Description:** Removes all direct use of the `component.Host.GetExporters` function so that it can be removed from the interface. **Link to tracking Issue:** Works towards open-telemetry/opentelemetry-collector#7370
**Description:** Remove the deprecated `GetExporters` function from `component.Host` **Link to tracking Issue:** <Issue number if applicable> Related to #7370
Moving to service 1.0 after #9987. The remaining part is to remove in contrib components and then remove from the service's |
@TylerHelmuth Should we remove this from the Collector v1 board based on #10643? |
@mx-psi based on the decision made in #10181 our As an aside, I think I would say that long term the |
Is your feature request related to a problem? Please describe.
component.Host.GetExporters
has a comment that statesThis is an experimental function that may change or even be removed completely.
With the addition of connectors we should further question whether this function should exist.Describe the solution you'd like
I'm proposing that we deprecate the function once the
service.connectors
featuregate is marked stable. (Currently proposed to become beta in #7369).This function is not only unnecessary, but potentially problematic for at least the following reasons:
The following components currently use this function:
routingprocessor
routes data directly to exporters. This component would be much more naturally implemented as a connector.spanmetricsprocessor
generates data and emits it directly to an exporter. Already ported to a connector.datadogprocessor
generates data and emits it directly to an exporter. Could easily be ported to a connector.servicegraphprocessor
generates data and emits it directly to an exporter. Already ported to a connector.k8sclusterreceiver
sends metadata directly to exporters. This is the only usage that is not replaced by connectors. However, the implementation is quite unusual and seems like it should be implemented as an extension anyways.component.Host
. Wouldn't be necessary at all.servicegraphconnector
still useshost.GetExporters
due being copied from the processor.The text was updated successfully, but these errors were encountered: