Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/servicegraph] Deprecate component #19737

Closed
djaglowski opened this issue Mar 15, 2023 · 8 comments · Fixed by #23996
Closed

[processor/servicegraph] Deprecate component #19737

djaglowski opened this issue Mar 15, 2023 · 8 comments · Fixed by #23996
Labels
connector/servicegraph never stale Issues marked with this label will be never staled and automatically removed processor/servicegraph Service graph processor

Comments

@djaglowski
Copy link
Member

Component(s)

connector/servicegraph, processor/servicegraph

Describe the issue you're reporting

This is a tracking issue relating to open-telemetry/opentelemetry-collector#7370

The processor has been reimplemented as a connector. (See #18389)

We should deprecate the processor when the code owners believe the time is appropriate.
@github-actions
Copy link
Contributor

Pinging code owners for processor/servicegraph: @jpkrohling @mapno. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for connector/servicegraph: @jpkrohling @mapno. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski mentioned this issue Mar 15, 2023
Open
8 tasks
@jpkrohling
Copy link
Member

I'll let @mapno and @kovrus confirm, but I talked to them, and we are OK with the plan.

@kovrus kovrus mentioned this issue Mar 29, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 29, 2023
@djaglowski djaglowski added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels May 30, 2023
@jpkrohling
Copy link
Member

@djaglowski, should the processor already be marked as deprecated? If so, I'll go ahead and mark it as such.

@djaglowski
Copy link
Member Author

@jpkrohling, it seems to me that it would be appropriate to deprecate it at this point. I believe we were just waiting for a code owner to give the go ahead. :)

@jpkrohling
Copy link
Member

Alright, I'm on it.

@jpkrohling jpkrohling mentioned this issue Jul 5, 2023
Merged
codeboten pushed a commit that referenced this issue Jul 12, 2023
@jpkrohling
[processor/servicegraph] Deprecate component (#23996)
17262f4 
Deprecated the component. 
Closes #19737
---------

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connector/servicegraph never stale Issues marked with this label will be never staled and automatically removed processor/servicegraph Service graph processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/servicegraph] Deprecate component jpkrohling/opentelemetry-collector-contrib
2 participants
@jpkrohling @djaglowski