Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory and new-style config for Jaeger exporter #36

Closed
tigrannajaryan opened this issue Jun 21, 2019 · 3 comments · Fixed by #228
Closed

Add factory and new-style config for Jaeger exporter #36

tigrannajaryan opened this issue Jun 21, 2019 · 3 comments · Fixed by #228
Assignees
@pjanotti
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
0.1.0

Comments

@tigrannajaryan
Copy link
Member

See OpenCensus exporter factory.go and config.go as an example.
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jun 28, 2019
@MohamedElqdusy
Copy link
Contributor

Hi @tigrannajaryan, I'd like to pick this one.

@tigrannajaryan
Copy link
Member Author

@MohamedElqdusy great! Assigned to you.

@pjanotti
Copy link
Contributor

pjanotti commented Jul 8, 2019

Sorry I missed this one: we need to do this via simple senders, that don't have their own queue and consistently handle service name. The exporter should not be based on the client library one.

@MohamedElqdusy MohamedElqdusy mentioned this issue Jul 8, 2019
Closed
@tigrannajaryan tigrannajaryan added this to the 0.1.0 milestone Jul 10, 2019
@pjanotti pjanotti mentioned this issue Aug 2, 2019
Merged
@pjanotti pjanotti assigned pjanotti and unassigned MohamedElqdusy Aug 2, 2019
@jpkrohling jpkrohling mentioned this issue Oct 28, 2021
Merged
bogdandrutu added a commit that referenced this issue Oct 28, 2021
@jpkrohling @bogdandrutu
@joe-elliott @jiwen624 @Ashmita152 @fangyi-zhou @crearys @pmalek-sumo @secat @sodabrew @pmalek @KKelvinLo @himanshu007-creator @u5surf @zchee @Aneurysm9 @loomis-relativity
Move opentelemetry-collector-builder to core (#4286)
4063a46 
* Initial commit

* Add CODEOWNERS file (#2)

* Add CODEOWNERS file

* Update CODEOWNERS

* Moved from github.com/observatorium/opentelemetry-collector-builder (#3)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* fixed panics (#6)

Signed-off-by: Joe Elliott <[email protected]>

* Replace master with main in CI and mergify files (#8)

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Bump to OpenTelemetry Collector 0.20.0 (#10)

Closes #9

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Explicitly enable Go modules in quickstart instructions (#13)

* Update to collector v0.21.0 (#17)

Fixes #16

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to collector v0.22.0 (#19)

* Download go modules before building (#20)

Fixes #14

* Add version command (#25)

Signed-off-by: Ashmita Bohara <[email protected]>

* Pass errors from cobra Execute back to main for correct exit code (#28)

* pass errors from cobra execute back to main

* print the error

* Update to collector v0.23.0 (#27)

* Generate a warning if the builder and collector base version mismatch (#30)

* Generate a warning if the builder and collector base version mismatch

* Show current default version in the warning message

* Update to OpenTelemetry Collector 0.24.0

* Don't use %w formatting with log.Fatal (#35)

* Update to OpenTelemetry Collector 0.25.0 (#36)

Signed-off-by: Serge Catudal <[email protected]>

* Update to 0.26.0 and update BuildInfo (#39)

* Sync build and CI Go versions at latest 1.16 (#34)

* Sync build and CI Go versions at latest 1.16

* Run go mod tidy

* Set go binary to use in the compilation phase in tests

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Add option to generate go code only (no compile) (#40)

* Issue#24 Add option to generate go code only (no compile)

* Update cmd/root.go logging

Suggested by @jpkkrohling

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* remove verbose help .. created by corba

* suggestion by jpkrohling to keep generateandcompile

* lint error: remove unused var

* reword cmd option and add back help message for default

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Don't reuse exec.Cmd (#42)

* Update to OpenTelemetry Collector 0.27.0 (#43)

* Add CI Badge (#47)

* Update to Collector v0.28.0 (#49)

* Update to Collector v0.28.0

Closes #48

Addresses the breaking API change in
#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <[email protected]>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <[email protected]>

* Account for go mod download in go1.17 not updating go.sum (#50)

* Update to collector v0.29.0 (#54)

* Update replaces.builder.yaml

* Update nocore.builder.yaml

* Update config.go

* Update README.md

* Update main.go

* Update to collector v0.30.0 (#57)

* cmd: fix module flag default value to github.com/open-telemetry (#58)

Signed-off-by: Koichi Shiraishi <[email protected]>

* Update to collector v0.31.0 (#60)

* Update to v0.33.0 (#62)

Signed-off-by: Anthony J Mirabella <[email protected]>

* Add excludes support to generated go.mod (#63)

Signed-off-by: Anthony J Mirabella <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

* Small cleanup for the builder files (#64)

Signed-off-by: Bogdan Drutu <[email protected]>

* Support building with Go 1.17 (#66)

* Support building with Go 1.17
Fixes #65

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update workflows to use Go 1.17

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Add gosec exceptions for exec.Command

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Update to OpenTelemetry core 0.34.0 (#68)

Fixes #67

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Upgrade to OpenTelemetry Collector 0.35.0 (#70)

Signed-off-by: Fangyi Zhou <[email protected]>

* Upgrade to OpenTelemetry Collector 0.36.0 (#76)

* Generate custom service code for Windows (#75)

* update main to include windows service code

* use main version from tag 0.35.0

* update main function

* align with upstream v0.36.0 tag

* dummy change to trigger build

* Revert "dummy change to trigger build"

This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f.

* Remove Core from Module type (#77)

Fixes #15

Signed-off-by: yugo-horie <[email protected]>

* release 0.37.0 (#78)

* release 0.37.0

* update use of NewCommand

* Move builder to subdirectory

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Joe Elliott <[email protected]>
Co-authored-by: Eric Yang <[email protected]>
Co-authored-by: Brian Gibbins <[email protected]>
Co-authored-by: Ashmita <[email protected]>
Co-authored-by: Fangyi Zhou <[email protected]>
Co-authored-by: Shaun Creary <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Serge Catudal <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Aaron Stone <[email protected]>
Co-authored-by: Kelvin Lo <[email protected]>
Co-authored-by: Himanshu <[email protected]>
Co-authored-by: Y.Horie <[email protected]>
Co-authored-by: Koichi Shiraishi <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Cal Loomis <[email protected]>
Co-authored-by: alrex <[email protected]>
@bogdandrutu bogdandrutu mentioned this issue Oct 28, 2021
Merged
bogdandrutu pushed a commit that referenced this issue Oct 28, 2021
@secat
Update to OpenTelemetry Collector 0.25.0 (#36)
4056de9 
Signed-off-by: Serge Catudal <[email protected]>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@thinkerou @rghetia
use function instead of global var (open-telemetry#36)
a606839 
* use function instead of global var

* fix lack return
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@rnburn
Add plugin support (open-telemetry#36)
4dd7a6b 
* Add code for dynamic loading

* Add a mock hook

* Fix CopyErrorMessage

* Set up loading example

* Add plugin example

* Add plugin example

* Make a noisy plugin

* Remove mock from sdk

* Add ci for testing plugin

* Reformat

* Remove noexcept from alias

* Add windows stub

* Add missing includes

* Document

* Reorganize

* Fix formatting

* Setup plugin test for windows

* Fix typo

* Fix windows script

* Fix windows script

* Fix typo

* Fix windows path

* Fill out windows testing

* Fix windows script

* Fix windows script

* Fix windows script

* Fix windows script

* Fix windows script

* Fill in windows loading code

* Use std::string for error message

* Fix example

* Use string for error_message

* Fix namespace error

* Add windows error handling

* Fix windows preprocessor error

* Fix signature

* Add tests for plugins

* Fix formatting

* Refactor plugin test

* Drop unused private section

* Update for master
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@andrzej-stencel
Add k8s container logs collection (open-telemetry#36)
431e451 
Fixes open-telemetry/opentelemetry-collector-contrib#2536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjanotti pjanotti

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Add jaeger thrift-http exporter pjanotti/opentelemetry-service
3 participants
@tigrannajaryan @pjanotti @MohamedElqdusy