Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Summary Metric for PrometheusReceiver #1913

Closed
JasonXZLiu opened this issue Oct 6, 2020 · 4 comments
Closed

Implement Summary Metric for PrometheusReceiver #1913

JasonXZLiu opened this issue Oct 6, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@JasonXZLiu
Copy link
Member

Is your feature request related to a problem? Please describe.

Prometheus Summary metrics are currently not supported and converted to the OTel metric data format. Under the specifications and design of the PrometheusReceiver (here), it mentions that Prometheus Summary metrics should be handled properly. However, when the PrometheusReceiver finds Summary metrics, the OTel Collector returns a Nil metric, resulting in dropped metrics.

The summary metric was previously implemented in OpenCensus and is a missing feature in OpenTelemetry.

Related to this issue: #1638

Describe the solution you'd like

We would like an implementation of the Summary metric (similar to the one in Prometheus) in OpenTelemetry such that the PrometheusReceiver can convert Prometheus summary metrics to OpenTelemetry summary metrics. In the current metrics.proto, only the gauge, sum, and histogram metric types are supported. However, the PrometheusReceiver design specifies that the Summary metric will be converted to a corresponding summary metrics with percentile values as shown here.

It seems like the OTEL receivers (including the PrometheusReceiver) convert first to the OpenCensus metric format (here) and then uses a separate method to convert to the OpenTelemetry metrics (here). I believe the PrometheusReceiver currently converts the Prometheus Summary metrics to OpenCensus correctly. However, the conversion between those OpenCensus metrics to OTel is currently not implemented (here).

-- cc @alolita @jmacd

@jmacd
Copy link
Contributor

jmacd commented Oct 30, 2020

This has been discussed in the Metrics SIG and we have agreed that a Summary data point should be added in the next release of OTLP. The protocol change is here: open-telemetry/opentelemetry-proto#227

I do not believe we need to add both integer- and floating-point forms of this data point. I would prefer to see that we remove OpenCensus data format where possible, but you're right that the OC->OTLP conversion should be fixed after this protocol change is finished.

@JasonXZLiu
Copy link
Member Author

JasonXZLiu commented Oct 30, 2020

Yes, sorry this proposal was originally created before the other two in OTel spec. I'm currently working on a PR to implement the OC->OTLP conversion (and vice versa) and generate the proper summary structs in the Collector (based on the proto change that you referred to above). Would love your feedback on the PR when it's up!

p.s. If it's possible, would you be able to assign this issue to me? Thank you!

@alolita
Copy link
Member

alolita commented Oct 31, 2020

@jmacd @bogdandrutu @tigrannajaryan can you please assign @JasonXZLiu to this issue - we will file a PR shortly.

@JasonXZLiu
Copy link
Member Author

Closing this issue as it's a duplicate of this bug (#1638).

@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…y#1913)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.37.0...v1.37.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…y#1913)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.59 to 1.24.60.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.59...1.24.60)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants