-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Conversion Between OC and OTel Summary Metric #2048
Implement Conversion Between OC and OTel Summary Metric #2048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 92.04% 92.15% +0.11%
==========================================
Files 278 278
Lines 16831 17120 +289
==========================================
+ Hits 15492 15777 +285
- Misses 921 923 +2
- Partials 418 420 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the data conversion related review to the approvers. I left some high level questions and suggestions.
This needs to wait for the proto change to be merged. |
61105ad
to
039b6bc
Compare
@tigrannajaryan do you suggest to not update now? This blocks some important feature for AWS. |
Note: This PR is based off the Summary datapoint proto (that has not been merged upstream) in this PR.
Description:
This PR has two main parts:
make genproto
andmake genpdata
commands).Link to tracking Issue: opentelemetry-specification/issues/1146 and opentelemetry-collector/issues/1638
A lot of the code in this PR is auto-generated from creating the structs and protos. The following files are were auto-generated:
Testing:
cc - @alolita