[chore] add fixes for otelcol-contrib to release pipeline #760
Conversation
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
| distribution: goreleaser-pro | ||
| version: ${{ env.GORELEASER_PRO_VERSION }} | ||
| workdir: distributions/${{ inputs.distribution }} | ||
| args: release --clean --split --timeout 2h --config .goreleaser-build.yaml --release-header-tmpl=../../.github/release-template.md |
There was a problem hiding this comment.
What happens when release --clean --split --timeout 2h --release-header-tmpl=../../.github/release-template.md is called again below?
There was a problem hiding this comment.
the build for otelcol-contrib is split between 2 different goreleaser config files as of #666. so the first call gets a different config than the second one. (.goreleaser-build.yaml and .goreleaser.yaml)
the first call will just build the binaries, the second one continues business as is, while importing the prebuilt binaries and it should then continue as usual
|
sounds good, I was gonna suggest the same thing |
|
closing this in favor of #762 |
|
@TylerHelmuth @atoulme @mx-psi the new PR is ready for review. I was able to properly test it with a goreleaser-pro token: Test release on my fork was successful, i linked the workflow runs and the test release in the PR |
This PR adds missing changes to the release pipeline that should have been part of #666