-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run linux package tests nightly against latest contrib main #666
base: main
Are you sure you want to change the base?
test: run linux package tests nightly against latest contrib main #666
Conversation
ccfa4e8
to
a24cc4e
Compare
86091e2
to
cce781a
Compare
14ab206
to
7e08c5f
Compare
d492610
to
9e0c3e6
Compare
c399793
to
860fc05
Compare
9bdc8fc
to
9f83a4d
Compare
@mx-psi i fixed all your remarks, pls re-review when you find some time :) |
Head branch was pushed to by a user without write access
I have re-run the CI but it keeps failing, can you take a look? Do you think it is related to the 2.4.6 update? |
yes i think it's related somehow. there were some changes to folder naming that i need to adapt to I believe. This will also be needed on the renovate PR |
Oki, if you'd rather revert the 2.4.6 update I'm also okay with that, just ping me on a revert PR :) |
Maybe i will wait until we merge the updated goreleaser version in main. That will require some manual changes as well I think. Maybe you could retrigger CI there and then let's see what happens. |
2e89b3e
to
5295ab7
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
163a32a
to
e4a05a5
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mx-psi i believe i'm done with all the review comments and refactoring etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I am bit scared about accidentally breaking the release pipeline with this change. There's a couple things that can be done here: a test release run on your fork and waiting until right after the next release to maximize the time we test this. What do you think?
you mean merging this only after the next release? |
Yep
Alright, if you find the time, I suppose it will fail when pushing to the Docker registry but if it passes until then that's a good test for me |
This PR enables nightly testing of the otelcol-contrib linux packages based on the latest main branch version of otelcol-contrib built in https://github.com/open-telemetry/opentelemetry-collector-contrib.
This change was made possible by splitting the otelcol-contrib gorelease config into 2 separate files, one for building and one for packaging/archives/docker images/etc.
(The split goreleaser build is a goreleaser pro feature)
Using the split building approach was the only viable option to achieve this. I did lots of research on this, it was talked about in the Collector SIG meeting and I also asked the GoReleaser folks for their help.
Consequences of this change:
Fixes #659