Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run linux package tests nightly against latest contrib main #666

Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Sep 19, 2024

This PR enables nightly testing of the otelcol-contrib linux packages based on the latest main branch version of otelcol-contrib built in https://github.com/open-telemetry/opentelemetry-collector-contrib.
This change was made possible by splitting the otelcol-contrib gorelease config into 2 separate files, one for building and one for packaging/archives/docker images/etc.
(The split goreleaser build is a goreleaser pro feature)

Using the split building approach was the only viable option to achieve this. I did lots of research on this, it was talked about in the Collector SIG meeting and I also asked the GoReleaser folks for their help.

Consequences of this change:

  • better testing
  • slightly less maintainability of the goreleaser files and generator code for otelcol-contrib since they have special handling now

Fixes #659

@mowies mowies force-pushed the nightly-package-tests branch 3 times, most recently from ccfa4e8 to a24cc4e Compare September 30, 2024 08:25
@mowies mowies force-pushed the nightly-package-tests branch from 86091e2 to cce781a Compare October 14, 2024 08:01
@mowies mowies force-pushed the nightly-package-tests branch from 14ab206 to 7e08c5f Compare October 30, 2024 08:06
@mowies mowies force-pushed the nightly-package-tests branch 3 times, most recently from d492610 to 9e0c3e6 Compare November 12, 2024 11:03
@mowies mowies force-pushed the nightly-package-tests branch from c399793 to 860fc05 Compare November 14, 2024 09:57
@mowies mowies force-pushed the nightly-package-tests branch from 9bdc8fc to 9f83a4d Compare November 21, 2024 12:40
@mowies mowies changed the title run package tests nightly against latest main test: run package tests nightly against latest contrib main Nov 21, 2024
@mowies mowies changed the title test: run package tests nightly against latest contrib main test: run linux package tests nightly against latest contrib main Nov 25, 2024
@mowies mowies marked this pull request as ready for review November 25, 2024 08:16
@mowies mowies requested a review from a team as a code owner November 25, 2024 08:16
@mowies mowies requested a review from fatsheep9146 November 25, 2024 08:16
.github/workflows/base-package-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
@mowies
Copy link
Member Author

mowies commented Nov 27, 2024

@mx-psi i fixed all your remarks, pls re-review when you find some time :)

@mx-psi mx-psi enabled auto-merge November 27, 2024 08:59
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Show resolved Hide resolved
.github/workflows/package-test.yaml Outdated Show resolved Hide resolved
cmd/goreleaser/internal/configure.go Show resolved Hide resolved
cmd/goreleaser/main.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 28, 2024 07:58

Head branch was pushed to by a user without write access

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

I have re-run the CI but it keeps failing, can you take a look? Do you think it is related to the 2.4.6 update?

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

yes i think it's related somehow. there were some changes to folder naming that i need to adapt to I believe. This will also be needed on the renovate PR

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

Oki, if you'd rather revert the 2.4.6 update I'm also okay with that, just ping me on a revert PR :)

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

Maybe i will wait until we merge the updated goreleaser version in main. That will require some manual changes as well I think. Maybe you could retrigger CI there and then let's see what happens.
PR link: #752

@mowies mowies force-pushed the nightly-package-tests branch from 2e89b3e to 5295ab7 Compare November 28, 2024 12:31
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the nightly-package-tests branch from 163a32a to e4a05a5 Compare November 28, 2024 14:13
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

@mx-psi i believe i'm done with all the review comments and refactoring etc.
would appreciate a re-review when you have time :)

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am bit scared about accidentally breaking the release pipeline with this change. There's a couple things that can be done here: a test release run on your fork and waiting until right after the next release to maximize the time we test this. What do you think?

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

you mean merging this only after the next release?
doing a release on my fork sounds good

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

you mean merging this only after the next release?

Yep

doing a release on my fork sounds good

Alright, if you find the time, I suppose it will fail when pushing to the Docker registry but if it passes until then that's a good test for me

@mowies
Copy link
Member Author

mowies commented Nov 29, 2024

Sounds good, I'll do the test release next week

@mowies
Copy link
Member Author

mowies commented Dec 2, 2024

i tried to do a test release but it's hard to do with so many otel specific things. Even after removing the container registry login steps, goreleaser needs the pro key for example. But here are the test runs that ran until the requirement for the goreleaser-pro key:

Builder
Core
Contrib
k8s
OTLP

In any case, this PR doesn't touch any of the release pipelines anyways.

@mx-psi mx-psi added this pull request to the merge queue Dec 2, 2024
Merged via the queue into open-telemetry:main with commit 1271690 Dec 2, 2024
48 checks passed
@mowies mowies deleted the nightly-package-tests branch December 2, 2024 12:51
@mowies
Copy link
Member Author

mowies commented Dec 2, 2024

@mx-psi so now it was still merged before the collector release 😅

@mx-psi
Copy link
Member

mx-psi commented Dec 2, 2024

@mx-psi so now it was still merged before the collector release 😅

Sorry, should have said something here before merging: I spoke with Antoine (this week's release manager) about this and he was fine to merge this before the release 😄

@mowies
Copy link
Member Author

mowies commented Dec 2, 2024

ah okok 😄

TylerHelmuth added a commit to TylerHelmuth/opentelemetry-collector-releases that referenced this pull request Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly linux package tests
3 participants