Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run linux package tests nightly against latest contrib main #666

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

mowies
Copy link
Member

@mowies mowies commented Sep 19, 2024

This PR enables nightly testing of the otelcol-contrib linux packages based on the latest main branch version of otelcol-contrib built in https://github.com/open-telemetry/opentelemetry-collector-contrib.
This change was made possible by splitting the otelcol-contrib gorelease config into 2 separate files, one for building and one for packaging/archives/docker images/etc.
(The split goreleaser build is a goreleaser pro feature)

Using the split building approach was the only viable option to achieve this. I did lots of research on this, it was talked about in the Collector SIG meeting and I also asked the GoReleaser folks for their help.

Consequences of this change:

  • better testing
  • slightly less maintainability of the goreleaser files and generator code for otelcol-contrib since they have special handling now

Fixes #659

@mowies mowies force-pushed the nightly-package-tests branch 3 times, most recently from ccfa4e8 to a24cc4e Compare September 30, 2024 08:25
@mowies mowies force-pushed the nightly-package-tests branch 3 times, most recently from d492610 to 9e0c3e6 Compare November 12, 2024 11:03
@mowies mowies changed the title run package tests nightly against latest main test: run package tests nightly against latest contrib main Nov 21, 2024
@mowies mowies changed the title test: run package tests nightly against latest contrib main test: run linux package tests nightly against latest contrib main Nov 25, 2024
@mowies mowies marked this pull request as ready for review November 25, 2024 08:16
@mowies mowies requested a review from a team as a code owner November 25, 2024 08:16
.github/workflows/base-package-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
@mowies
Copy link
Member Author

mowies commented Nov 27, 2024

@mx-psi i fixed all your remarks, pls re-review when you find some time :)

.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/base-ci-goreleaser.yaml Show resolved Hide resolved
.github/workflows/package-test.yaml Outdated Show resolved Hide resolved
cmd/goreleaser/internal/configure.go Show resolved Hide resolved
cmd/goreleaser/main.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 28, 2024 07:58

Head branch was pushed to by a user without write access

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

I have re-run the CI but it keeps failing, can you take a look? Do you think it is related to the 2.4.6 update?

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

yes i think it's related somehow. there were some changes to folder naming that i need to adapt to I believe. This will also be needed on the renovate PR

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

Oki, if you'd rather revert the 2.4.6 update I'm also okay with that, just ping me on a revert PR :)

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

Maybe i will wait until we merge the updated goreleaser version in main. That will require some manual changes as well I think. Maybe you could retrigger CI there and then let's see what happens.
PR link: #752

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

@mx-psi i believe i'm done with all the review comments and refactoring etc.
would appreciate a re-review when you have time :)

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am bit scared about accidentally breaking the release pipeline with this change. There's a couple things that can be done here: a test release run on your fork and waiting until right after the next release to maximize the time we test this. What do you think?

@mowies
Copy link
Member Author

mowies commented Nov 28, 2024

you mean merging this only after the next release?
doing a release on my fork sounds good

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2024

you mean merging this only after the next release?

Yep

doing a release on my fork sounds good

Alright, if you find the time, I suppose it will fail when pushing to the Docker registry but if it passes until then that's a good test for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly linux package tests
2 participants