Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary context in prometheus receiver #9766

Merged
merged 1 commit into from
May 6, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 5, 2022
@bogdandrutu bogdandrutu requested a review from a team May 5, 2022 23:22
@codeboten
Copy link
Contributor

There is a test failure which appears unrelated, I haven't seen this test fail in the past though.

=== RUN   TestLogsTransformProcessor/simpleTest
    processor_test.go:140: 
        	Error Trace:	processor_test.go:140
        	Error:      	Not equal: 
        	            	expected: internal.Logs{orig:(*v1.ExportLogsServiceRequest)(0xc00000ff80)}
        	            	actual  : internal.Logs{orig:(*v1.ExportLogsServiceRequest)(0xc00000ffc8)}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -16,6 +16,6 @@
        	            	        (*v1.LogRecord)({
        	            	-        TimeUnixNano: (uint64) 1640995200000000000,
        	            	+        TimeUnixNano: (uint64) 0,
        	            	         ObservedTimeUnixNano: (uint64) 1641081600000000000,
        	            	-        SeverityNumber: (v1.SeverityNumber) 9,
        	            	-        SeverityText: (string) (len=4) "Info",
        	            	+        SeverityNumber: (v1.SeverityNumber) 0,
        	            	+        SeverityText: (string) "",
        	            	         Body: (v1.AnyValue) {
        	            	@@ -25,22 +25,3 @@
        	            	         },
        	            	-        Attributes: ([]v1.KeyValue) (len=3) {
        	            	-         (v1.KeyValue) {
        	            	-          Key: (string) (len=3) "msg",
        	            	-          Value: (v1.AnyValue) {
        	            	-           <max depth reached>
        	            	-          }
        	            	-         },
        	            	-         (v1.KeyValue) {
        	            	-          Key: (string) (len=3) "sev",
        	            	-          Value: (v1.AnyValue) {
        	            	-           <max depth reached>
        	            	-          }
        	            	-         },
        	            	-         (v1.KeyValue) {
        	            	-          Key: (string) (len=4) "time",
        	            	-          Value: (v1.AnyValue) {
        	            	-           <max depth reached>
        	            	-          }
        	            	-         }
        	            	-        },
        	            	+        Attributes: ([]v1.KeyValue) <nil>,
        	            	         DroppedAttributesCount: (uint32) 0,
        	Test:       	TestLogsTransformProcessor/simpleTest

@codeboten
Copy link
Contributor

Ah i see #9761, please rebase and push again. Looks like the test has been disabled: #9773

@bogdandrutu bogdandrutu merged commit d6986f2 into open-telemetry:main May 6, 2022
@bogdandrutu bogdandrutu deleted the rmctx branch May 6, 2022 17:06
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants