Remove unnecessary context in prometheus receiver (open-telemetry#9766)

Signed-off-by: Bogdan Drutu <[email protected]>
djaglowski · May 10, 2022 · 31b699a · 31b699a
1 parent 133b5da
commit 31b699a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/receiver/prometheusreceiver/internal/ocastore.go b/receiver/prometheusreceiver/internal/ocastore.go
@@ -29,8 +29,6 @@ var idSeq int64
 
 // OcaStore translates Prometheus scraping diffs into OpenCensus format.
 type OcaStore struct {
-	ctx context.Context
-
 	sink                 consumer.Metrics
 	jobsMap              *JobsMap
 	useStartTimeMetric   bool
@@ -43,7 +41,6 @@ type OcaStore struct {
 
 // NewOcaStore returns an ocaStore instance, which can be acted as prometheus' scrape.Appendable
 func NewOcaStore(
-	ctx context.Context,
 	sink consumer.Metrics,
 	set component.ReceiverCreateSettings,
 	gcInterval time.Duration,
@@ -56,7 +53,6 @@ func NewOcaStore(
 		jobsMap = NewJobsMap(gcInterval)
 	}
 	return &OcaStore{
-		ctx:                  ctx,
 		sink:                 sink,
 		settings:             set,
 		jobsMap:              jobsMap,

diff --git a/receiver/prometheusreceiver/metrics_receiver.go b/receiver/prometheusreceiver/metrics_receiver.go
@@ -77,10 +77,7 @@ func (r *pReceiver) Start(_ context.Context, host component.Host) error {
 		}
 	}()
 
-	// Per component.Component Start instructions, for async operations we should not use the
-	// incoming context, it may get cancelled.
 	r.ocaStore = internal.NewOcaStore(
-		context.Background(),
 		r.consumer,
 		r.settings,
 		gcInterval(r.cfg.PrometheusConfig),