[receiver/github] update metrics and attributes to match latest semantics and change scraper key name #36714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `ref.name` becomes `vcs.ref.head.name` * `ref.type` becomes `vcs.ref.head.type`
adrielp
requested review from
andrzej-stencel,
crobert-1,
TylerHelmuth and
a team
as code owners
3 tasks
andrzej-stencel
approved these changes
Dec 11, 2024
songy23
added
ready to merge
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…tics and change scraper key name (open-telemetry#36714) #### Description Breaking: Updates various different metrics and attributes to match the latest semantic conventions (1.28+). Also updates the scraper key name. Most of the conventions are in 1.28 while a few attributes are merged in and will be released in 1.29. * Change the `github` scraper key to `scraper` * Add `vcs.repository.url.full` attribute * Change attribute `repository.name` to `vcs.repository.name` * Change attribute `ref.name` to `vcs.ref.head.name` * Change attribute `ref.type` to `vcs.ref.head.type` * Change attribute `change.state` to `vcs.change.state` * Add attribute `vcs.revision_delta.direction` with `ahead` and `behind` values * Change metric `vcs.repository.ref.revisions_ahead` to `vcs.ref.revisions_delta` with `vcs.revision_delta.direction=ahead` * Change metric `vcs.repository.ref.revisions_behind` to `vcs.ref.revisions_delta` with `vcs.revision_delta.direction=behind` * Change metric `vcs.repository.ref.count` to `vcs.ref.count` * Change metric `vcs.repository.ref.time` to `vcs.ref.time` * Add attribute `vcs.line_change.type` with `added` and `removed` values * Change metric `vcs.repository.ref.lines_added` to `vcs.ref.lines_delta` with `vcs.line_change.type=added` * Change metric `vcs.repository.ref.lines_removed` to `vcs.ref.lines_delta` with `vcs.line_change.type=removed` * Change metric `vcs.repository.contributor.count` to `vcs.contributor.count` * Change metric `vcs.repository.change.time_open` to `vcs.change.duration` with `vcs.change.state=open` * Change metric `vcs.repository.change.time_to_approval` to `vcs.change.time_to_approval` * Change metric `vcs.repository.change.time_to_merge` to `vcs.change.time_to_merge` * Change metric `vcs.repository.change.count` to `vcs.change.count` #### Testing In addition to the normal testing of the code, I additionally built the receiver into a collector to observe runtime behavior. #### Documentation Update generated docs and readme with scraper change.
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
…tics and change scraper key name (open-telemetry#36714) #### Description Breaking: Updates various different metrics and attributes to match the latest semantic conventions (1.28+). Also updates the scraper key name. Most of the conventions are in 1.28 while a few attributes are merged in and will be released in 1.29. * Change the `github` scraper key to `scraper` * Add `vcs.repository.url.full` attribute * Change attribute `repository.name` to `vcs.repository.name` * Change attribute `ref.name` to `vcs.ref.head.name` * Change attribute `ref.type` to `vcs.ref.head.type` * Change attribute `change.state` to `vcs.change.state` * Add attribute `vcs.revision_delta.direction` with `ahead` and `behind` values * Change metric `vcs.repository.ref.revisions_ahead` to `vcs.ref.revisions_delta` with `vcs.revision_delta.direction=ahead` * Change metric `vcs.repository.ref.revisions_behind` to `vcs.ref.revisions_delta` with `vcs.revision_delta.direction=behind` * Change metric `vcs.repository.ref.count` to `vcs.ref.count` * Change metric `vcs.repository.ref.time` to `vcs.ref.time` * Add attribute `vcs.line_change.type` with `added` and `removed` values * Change metric `vcs.repository.ref.lines_added` to `vcs.ref.lines_delta` with `vcs.line_change.type=added` * Change metric `vcs.repository.ref.lines_removed` to `vcs.ref.lines_delta` with `vcs.line_change.type=removed` * Change metric `vcs.repository.contributor.count` to `vcs.contributor.count` * Change metric `vcs.repository.change.time_open` to `vcs.change.duration` with `vcs.change.state=open` * Change metric `vcs.repository.change.time_to_approval` to `vcs.change.time_to_approval` * Change metric `vcs.repository.change.time_to_merge` to `vcs.change.time_to_merge` * Change metric `vcs.repository.change.count` to `vcs.change.count` #### Testing In addition to the normal testing of the code, I additionally built the receiver into a collector to observe runtime behavior. #### Documentation Update generated docs and readme with scraper change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking: Updates various different metrics and attributes to match the latest semantic conventions (1.28+). Also updates the scraper key name.
Most of the conventions are in 1.28 while a few attributes are merged in and will be released in 1.29.
githubscraper key toscrapervcs.repository.url.fullattributerepository.nametovcs.repository.nameref.nametovcs.ref.head.nameref.typetovcs.ref.head.typechange.statetovcs.change.statevcs.revision_delta.directionwithaheadandbehindvaluesvcs.repository.ref.revisions_aheadtovcs.ref.revisions_deltawithvcs.revision_delta.direction=aheadvcs.repository.ref.revisions_behindtovcs.ref.revisions_deltawithvcs.revision_delta.direction=behindvcs.repository.ref.counttovcs.ref.countvcs.repository.ref.timetovcs.ref.timevcs.line_change.typewithaddedandremovedvaluesvcs.repository.ref.lines_addedtovcs.ref.lines_deltawithvcs.line_change.type=addedvcs.repository.ref.lines_removedtovcs.ref.lines_deltawithvcs.line_change.type=removedvcs.repository.contributor.counttovcs.contributor.countvcs.repository.change.time_opentovcs.change.durationwithvcs.change.state=openvcs.repository.change.time_to_approvaltovcs.change.time_to_approvalvcs.repository.change.time_to_mergetovcs.change.time_to_mergevcs.repository.change.counttovcs.change.countTesting
In addition to the normal testing of the code, I additionally built the receiver into a collector to observe runtime behavior.
Documentation
Update generated docs and readme with scraper change.