[chore] Run make gengithub on PRs #36023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
force-pushed
the
make-gengithub-prs
branch
from
e26a4ec to
a50475b
Compare
evan-bradley
force-pushed
the
make-gengithub-prs
branch
from
a50475b to
9fad8f8
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closing this in favor of #36285. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We consistently have issues with
make gengithubfailing on main because we don't verify in CI that it is working in PRs. With this PR, we run it just like our other committed-code checks.