Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/routing] Add support for OTTL conditions #35731

Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Oct 10, 2024

This is a minor quality of life improvement which addresses a limitation noted in the connector's readme.

The use of statements is still useful, as a user may wish to delete a field used exclusively for routing. For the sake of simplicity, conditions are converted into statements by prepending route() where.

@github-actions github-actions bot requested review from jpkrohling and mwear October 10, 2024 16:22
@djaglowski djaglowski marked this pull request as ready for review October 10, 2024 17:38
@djaglowski djaglowski requested a review from a team as a code owner October 10, 2024 17:38
@djaglowski djaglowski force-pushed the routing-connector-conditions branch from ac8ba4c to 64b951c Compare October 10, 2024 17:47
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit cc72277 into open-telemetry:main Oct 11, 2024
158 checks passed
@djaglowski djaglowski deleted the routing-connector-conditions branch October 11, 2024 01:39
@github-actions github-actions bot added this to the next release milestone Oct 11, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants