Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate ottl field in subs and bridges with condition #91

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Nov 5, 2024

Overview

Breaking Changes & Feature

Testing & Miscellaneous

  • Added unit tests to verify the new feature and adjusted existing ones accordingly.
  • Added a new end-to-end (e2e) test for bridges (this was a leftover I had forgotten to include in my previous PR).
  • Fixed some minor issues (ref: f51a0cd).

Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the feat/switch-to-condition branch from 89106b1 to 591526d Compare November 5, 2024 16:21
@csatib02 csatib02 added the enhancement New feature or request label Nov 5, 2024
@VincentS
Copy link

VincentS commented Nov 6, 2024

Could you add some additional documentation / examples of the thing you added for users ?

@csatib02 csatib02 force-pushed the feat/switch-to-condition branch from 591526d to 0219159 Compare November 6, 2024 12:57
@csatib02 csatib02 self-assigned this Nov 6, 2024
@csatib02
Copy link
Member Author

csatib02 commented Nov 6, 2024

Hi @VincentS,

I've just completed this PR, so the description is filled out.

Cheers

@csatib02 csatib02 marked this pull request as ready for review November 6, 2024 13:17
@csatib02 csatib02 marked this pull request as draft November 6, 2024 13:52
@csatib02 csatib02 force-pushed the feat/switch-to-condition branch 4 times, most recently from ef8b605 to 7c24a8c Compare November 7, 2024 08:18
Also added a new e2e test-case for bridges.

Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the feat/switch-to-condition branch from 7c24a8c to 6cd0472 Compare November 7, 2024 08:22
@csatib02 csatib02 marked this pull request as ready for review November 7, 2024 08:22
@csatib02 csatib02 changed the title feat: make conditions and other RoutingConnector config opts available feat: deprecate ottl field in subs and bridges with condition Nov 7, 2024
@csatib02 csatib02 merged commit 9e3cf30 into main Nov 7, 2024
11 checks passed
@csatib02 csatib02 deleted the feat/switch-to-condition branch November 7, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants