[receiver/sapm] - follow receiver contract #35300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atoulme this is good to go now! PTAL |
VihasMakwana
changed the title
VihasMakwana
force-pushed
the
sapm-receiver-contract
branch
2 times, most recently
from
f6ed499 to
7ab132c
Compare
VihasMakwana
force-pushed
the
sapm-receiver-contract
branch
from
7ab132c to
dca4429
Compare
VihasMakwana
changed the title
atoulme
reviewed
Oct 1, 2024
| "go.opentelemetry.io/collector/consumer/consumererror" | ||
| ) | ||
|
|
||
| func HTTPError(w http.ResponseWriter, err error) { |
There was a problem hiding this comment.
are you really going to reuse that code outside of sapmreceiver?
There was a problem hiding this comment.
yes. look at this PR #35327.
It's for loki receiver.
atoulme
approved these changes
Oct 1, 2024
|
@atoulme merge conflicts are now resolved. I guess we can merge this. |
mwear
approved these changes
Oct 4, 2024
mwear
added
the
ready to merge
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
**Description:** This is my first PR to ensure that all network receivers adhere to [the contract](https://github.com/open-telemetry/opentelemetry-collector/blob/df3c9e38a80ccc3b14705462be2e2e51c628a3b3/receiver/doc.go#L10) and maintain the correct order of operations. I also plan to submit additional PRs for other receivers in the future. Follow receiver contract for `sapmreceiver`. This also includes an internal `errorutil` package which will be used by other network receivers as well. **Link to tracking Issue:** open-telemetry#5909 **Testing:** Added
MovieStoreGuy
pushed a commit
that referenced
this pull request
Oct 24, 2024
#35300 introduced a common methodology intended to be used by network receivers to follow [the contract](https://github.com/open-telemetry/opentelemetry-collector/blob/df3c9e38a80ccc3b14705462be2e2e51c628a3b3/receiver/doc.go#L10) and maintain the correct order of operations. This PR re-uses that for datadog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is my first PR to ensure that all network receivers adhere to the contract and maintain the correct order of operations. I also plan to submit additional PRs for other receivers in the future.
Follow receiver contract for
sapmreceiver.This also includes an internal
errorutilpackage which will be used by other network receivers as well.Link to tracking Issue: #5909
Testing: Added