Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/datadog]: follow receiver contract #35975

Merged

Conversation

VihasMakwana
Copy link
Contributor

#35300 introduced a common methodology intended to be used by network receivers to follow the contract and maintain the correct order of operations. This PR re-uses that for datadog.

VihasMakwana and others added 2 commits October 24, 2024 11:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that I had noticed, but otherwise seems reasonable.

receiver/datadogreceiver/receiver_test.go Outdated Show resolved Hide resolved
receiver/datadogreceiver/receiver_test.go Outdated Show resolved Hide resolved
@VihasMakwana
Copy link
Contributor Author

@MovieStoreGuy this is ready for another look!

@MovieStoreGuy MovieStoreGuy merged commit fd8dce8 into open-telemetry:main Oct 24, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants