[exporter/elasticsearch] Add exponential histogram support #34818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
force-pushed
the
exponential-histogram
branch
from
4d0f813 to
587e05a
Compare
felixbarny
reviewed
Aug 23, 2024
|
|
||
| if zeroCount := dp.ZeroCount(); zeroCount != 0 { | ||
| counts.AppendEmpty().SetInt(int64(zeroCount)) | ||
| // FIXME: do we really have to take the median of last negative and first positive, instead of using 0? |
There was a problem hiding this comment.
I'd expect us to be able to just use 0. If the offsets if the positive and negative scale are the same, the midpoint is always zero. If the offsets are different, I don't think the midpoint value is meaningful. As the zero count is the count of values that are zero (or within the zero_threshold), I think we should just use 0 as the value.
felixbarny
approved these changes
Sep 4, 2024
exporter/elasticsearchexporter/internal/exphistogram/exphistogram.go
Outdated
Show resolved
Hide resolved
lahsivjar
approved these changes
Sep 5, 2024
andrzej-stencel
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…metry#34818) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Convert exponential histograms to T-digest histograms supported by Elasticsearch **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#34813 **Testing:** <Describe what testing was performed and which tests were added.> Unit tests and exporter test **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Convert exponential histograms to T-digest histograms supported by Elasticsearch
Link to tracking Issue:
Fixes #34813
Testing:
Unit tests and exporter test
Documentation: