Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] Support exponential histogram #34813

Closed
carsonip opened this issue Aug 22, 2024 · 2 comments · Fixed by #34818
Closed

[exporter/elasticsearch] Support exponential histogram #34813

carsonip opened this issue Aug 22, 2024 · 2 comments · Fixed by #34818
Labels
enhancement New feature or request exporter/elasticsearch

Comments

@carsonip
Copy link
Contributor

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

There is no exponential histogram support in elasticsearch exporter now. It means exponential histograms are ignored. As Elasticsearch does not support native exponential histogram at the moment, exponential histograms in opentelemetry should be converted to T-digest and indexed.

Describe the solution you'd like

Convert to exponential histograms to Elasticsearch compatible format and index them.

Describe alternatives you've considered

No response

Additional context

No response
@carsonip carsonip added enhancement New feature or request needs triage New item requiring triage labels Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

This makes sense to me, and the issue was filed by code owner. Removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Aug 22, 2024
@carsonip carsonip mentioned this issue Aug 22, 2024
Merged
@github-actions github-actions bot mentioned this issue Aug 27, 2024
Closed
andrzej-stencel pushed a commit that referenced this issue Sep 5, 2024
@carsonip
[exporter/elasticsearch] Add exponential histogram support (#34818)
4c490fe 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Convert exponential histograms to T-digest histograms supported by
Elasticsearch

**Link to tracking Issue:** <Issue number if applicable>

Fixes #34813

**Testing:** <Describe what testing was performed and which tests were
added.>

Unit tests and exporter test

**Documentation:** <Describe the documentation added.>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@carsonip @f7o
[exporter/elasticsearch] Add exponential histogram support (open-tele…
0822753 
…metry#34818)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Convert exponential histograms to T-digest histograms supported by
Elasticsearch

**Link to tracking Issue:** <Issue number if applicable>

Fixes open-telemetry#34813

**Testing:** <Describe what testing was performed and which tests were
added.>

Unit tests and exporter test

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/elasticsearch] Add exponential histogram support carsonip/opentelemetry-collector-contrib
2 participants
@carsonip @crobert-1