Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/exceptionsconnector] Fix dimensions configuration did not take effect for resource attributes #34604

Merged

Conversation

JaredTan95
Copy link
Member

Description: Fix dimensions configuration did not take effect for resource attributes

Link to tracking Issue: #34603

Testing:

Documentation:

@JaredTan95
Copy link
Member Author

@jpkrohling @marctc How about making getDimensionValue in spanmetrics and getDimensionValue in exceptionsconnector as a tool function and move to intrenal pkg?

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@marctc
Copy link
Contributor

marctc commented Aug 12, 2024

@jpkrohling @marctc How about making getDimensionValue in spanmetrics and getDimensionValue in exceptionsconnector as a tool function and move to intrenal pkg?

makes sense! maybe you could open a github issue to track it

@mx-psi mx-psi merged commit 40e16d6 into open-telemetry:main Aug 13, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 13, 2024
@JaredTan95 JaredTan95 deleted the fix_exception_connector_dimensions branch August 27, 2024 14:27
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…take effect for resource attributes (open-telemetry#34604)

**Description:** Fix dimensions configuration did not take effect for
resource attributes
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** open-telemetry#34603

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Jared Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants