making getDimensionValue in spanmetrics and getDimensionValue in exceptionsconnector as a tool function and move to intrenal pkg
#34627
Assignees
Labels
Comments
JaredTan95
added
enhancement
|
Pinging code owners for connector/exceptions: @jpkrohling @marctc. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
Pinging code owners for connector/spanmetrics: @portertech @Frapschen. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
jpkrohling
pushed a commit
that referenced
this issue
Sep 6, 2024
…a common function. (#34908) **Description:** refactoring getDimensionValue func as util func for spanmetricsconnector,servicegraphconnector,exceptionconnector common usage <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** #34627 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this issue
Sep 12, 2024
…a common function. (open-telemetry#34908) **Description:** refactoring getDimensionValue func as util func for spanmetricsconnector,servicegraphconnector,exceptionconnector common usage <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#34627 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this issue
Oct 4, 2024
…a common function. (open-telemetry#34908) **Description:** refactoring getDimensionValue func as util func for spanmetricsconnector,servicegraphconnector,exceptionconnector common usage <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#34627 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
makes sense! maybe you could open a github issue to track it
Originally posted by @marctc in #34604 (comment)
The text was updated successfully, but these errors were encountered: