-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/statsd] log only non-EOF errors when reading payload received via TCP #33978
Conversation
…ed via TCP Signed-off-by: Florian Bacher <[email protected]>
…ed via TCP Signed-off-by: Florian Bacher <[email protected]>
Have you been able to test to ensure the message is no longer logged for EOF? |
Yes, I did some manual testing to verify the message is not logged.
And sent a metric using the following command:
Which resulted in the following logs:
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description: This PR modifies the tcp server of the statsd receiver to log errors only if they are not an
io.EOF
, as this one is expected when the payload has been read completely.Link to tracking Issue: #33951
Testing: The affected function has already been covered by existing tests. The only thing changed was whether to log the error or not.
Documentation: None required, as there have been no changes from user perspective