-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP Statsd Receiver is not able to read payload #33951
Comments
Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi, I was looking into this and also encountered this error log. However the metric i have sent seemed to have been received correctly. This was the command i used:
I have also created a PR to not log an error when an |
@bacherfl thanks for the reply. I have recreated your example and can confirm that the metric is logged when fired that way. I'm still not having any luck with the veneur-emit tool, which I had been relying on to programmatically emit statsd metrics for testing, but perhaps this is a bug on that side and not the tcp receiver. Feel free to close this when your PR is merged (or it can be closed before since the two aren't 100% related. Thanks again. |
…ed via TCP (#33978) **Description:** This PR modifies the tcp server of the statsd receiver to log errors only if they are not an `io.EOF`, as this one is expected when the payload has been read completely. **Link to tracking Issue:** #33951 **Testing:** The affected function has already been covered by existing tests. The only thing changed was whether to log the error or not. **Documentation:** None required, as there have been no changes from user perspective --------- Signed-off-by: Florian Bacher <[email protected]>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
If this is a Veneur emit issue, please consider opening an issue in veneur and link this one. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
receiver/statsd
What happened?
Description
TCP Statsd Receiver can't decode payload
Steps to Reproduce
I've deployed the veneur-emit docker image and have it setup to emit metrics to a GCP LB in front of some collector pods using the statsd receiver set to TCP transport mode. If I set veneur-emit to ship the same metric via UDP to an agent running the statsd receiver with UDP set as the transport, I see my metrics processed correctly.
Expected Result
Statsd Metrics are ingested and processed over TCP the same as they are UDP
Actual Result
debug [email protected]/reporter.go:46 TCP transport (10.3.5.124:8128) Error reading payload: EOF {"kind": "receiver", "name": "statsd", "data_type": "metrics"}
Veneur Emit command
Collector version
0.103.0
Environment information
Environment
GKE 1.28
OpenTelemetry Collector configuration
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: