[receiver/windowsperfcounters] Returning partial errors for failures #32370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislbs
force-pushed
the
feature/win-perf-receiver-partial-errors
branch
2 times, most recently
from
0c8f515 to
37bb1b3
Compare
Returning partial errors for failures during scraping to prevent throwing out all successfully retrieved metrics.
chrislbs
force-pushed
the
feature/win-perf-receiver-partial-errors
branch
from
37bb1b3 to
a8d0f39
Compare
|
Am I missing something to get this PR completed? |
|
LGTM! Can't approve it yet as I'm not a code owner just yet, though :P |
|
@alxbl Thank you! Also, feel free to approve or review any PR, whether you are a codeowner or not :) All reviews are welcome, no matter what your formal role is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning partial errors for failures during scraping to prevent throwing out all successfully retrieved metrics.
Description: Fixing a bug where a single instance of a windows performance object prevents metrics for all other valid instances from being published.
Link to tracking Issue: 16712
Testing: I added additional tests that verifies if some scrapers fail to retrieve metrics, the ones that don't fail continue to publish their metrics.
Documentation: