-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winperfcounters receiver reports no metrics if any scraper fails #16712
Comments
/label receiver/windowsperfcountersreceiver |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
…32370) Returning partial errors for failures during scraping to prevent throwing out all successfully retrieved metrics. **Description:** Fixing a bug where a single instance of a windows performance object prevents metrics for all other valid instances from being published. **Link to tracking Issue:** [16712](#16712) **Testing:** I added additional tests that verifies if some scrapers fail to retrieve metrics, the ones that don't fail continue to publish their metrics. **Documentation:**
Component(s)
receiver/windowsperfcounters
What happened?
Description
In the windows perf counter receiver, if any instance or object fails to receive, all metrics are thrown away rather than just the scrapers that failed to successfully read.
Steps to Reproduce
Create a windowsperfcounter receiver for an instance that exists, and another that doesn't.
Expected Result
Metrics will be received and exported for the perf counter instance that exists.
Actual Result
Metrics are not received or exported for the perf counter instance that exists.
Collector version
v0.66.0
Environment information
No response
OpenTelemetry Collector configuration
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: