Fixed bug with batch's creation parameters #31657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Took me awhile to sort out the CLA, but it's good now. |
dmitryax
approved these changes
Mar 25, 2024
dmitryax
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a new Batch is created, it's slice capacity for the number of records should be set to the maximum number of records, not the max record size, an error that can cause memory to be allocated frequently.
awskinesisexporter/internal/batch/batch.go#L76-L82
awskinesisexporter/internal/batch/batch.go#L28-L29
This is a copy of the original PR with the same fix found here:
#20862
I've simply made the change to the tests that was requested in the original PR.
Link to tracking Issue:
Fixes #20914