Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awskinesis exporter records capacity is set too large #20914

Closed
boysusu opened this issue Apr 17, 2023 · 3 comments · Fixed by #31657
Closed

awskinesis exporter records capacity is set too large #20914

boysusu opened this issue Apr 17, 2023 · 3 comments · Fixed by #31657
Assignees
@boysusu
Labels
closed as inactive exporter/awskinesis Stale

Comments

@boysusu
Copy link
Contributor

boysusu commented Apr 17, 2023

Component(s)

exporter/awskinesis

Describe the issue you're reporting

When a new Batch is created, it's slice capacity for the number of records should be set to the maximum number of records, not the max record size, an error that can cause memory to be allocated frequently.
awskinesisexporter/internal/batch/batch.go#L76-L82
awskinesisexporter/internal/batch/batch.go#L28-L29
@boysusu boysusu added the needs triage New item requiring triage label Apr 17, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@boysusu boysusu mentioned this issue Apr 17, 2023
Closed
@atoulme atoulme removed the needs triage New item requiring triage label Apr 17, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2023
@klhuff klhuff mentioned this issue Mar 8, 2024
Merged
dmitryax pushed a commit that referenced this issue Mar 25, 2024
@klhuff
Fixed bug with batch's creation parameters (#31657)
9aa10d9 
Description:
When a new Batch is created, it's slice capacity for the number of
records should be set to the maximum number of records, not the max
record size, an error that can cause memory to be allocated frequently.

[awskinesisexporter/internal/batch/batch.go#L76-L82](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L76-L82)

[awskinesisexporter/internal/batch/batch.go#L28-L29](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/41b5f81343828a37f709acf7788b08eb2c66730e/exporter/awskinesisexporter/internal/batch/batch.go#L28-L29)


This is a copy of the original PR with the same fix found here:

#20862

I've simply made the change to the tests that was requested in the
original PR.

Link to tracking Issue:
Fixes
#20914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boysusu boysusu

Labels
closed as inactive exporter/awskinesis Stale
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @boysusu