elasticexporter: don't return error on invalid tags #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
If `http.url` is provided, and does not conform to the opentelemetry conventions, do not return an error if URL parsing fails. Instead, just record the value as-is in a label. For example, the OpenTracing instrumentation for Go's net/http client sends host:port in some cases: https://github.com/opentracing-contrib/go-stdlib/blob/cf7a6c988dc994e945d2715565026f3cc8718689/nethttp/client.go#L255
axw
force-pushed
the
elastic-parse-invalid-urls
branch
from
3b7c996 to
f1a3428
Compare
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 79.24% 79.44% +0.20%
==========================================
Files 163 163
Lines 8354 8348 -6
==========================================
+ Hits 6620 6632 +12
+ Misses 1369 1357 -12
+ Partials 365 359 -6
Continue to review full report at Codecov.
|
owais
approved these changes
Jun 5, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
If `http.url` is provided, and does not conform to the opentelemetry conventions, do not return an error if URL parsing fails. Instead, just record the value as-is in a label. For example, the OpenTracing instrumentation for Go's net/http client sends host:port in some cases: https://github.com/opentracing-contrib/go-stdlib/blob/cf7a6c988dc994e945d2715565026f3cc8718689/nethttp/client.go#L255
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Rename fanoutprocessor to FanOutConnector This implements open-telemetry/opentelemetry-collector#283 * PR fixes
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* bump dependent module versions. * update example hashes too.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If an
http.urlattribute is provided, and does not conform to theopentelemetry conventions, do not return an error if URL parsing fails.
Instead, just record the value as-is in a label.
For example, the OpenTracing instrumentation for Go's net/http client sends host:port in some cases: https://github.com/opentracing-contrib/go-stdlib/blob/cf7a6c988dc994e945d2715565026f3cc8718689/nethttp/client.go#L255
Testing:
Tested manually with Jaeger HotR.O.D. -> OpenTelemetry Collector -> Elastic APM
(This is how we found the issue in the first place.)
Added unit tests.