-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: OpenTelemetry Elastic exporter #3845
Conversation
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
What do you mean it didn't like it? Were there errors? Dropped transaction/spans? |
Ah, sorry. This, repeated:
But I was able to receive data in ESS. Lots of spans though: I just figured it was user error or Jaeger not playing nicely with Otel. If you want to try it out, here's the docker-compose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just a handful of comments, nothing major.
I'll have a look at what's going on with Jaeger/HotROD data, sounds like a bug in the exporter. Thanks for highlighting that issue.
I've made a change to the exporter to gracefully handle the |
Co-authored-by: Andrew Wilkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Codecov Report
@@ Coverage Diff @@
## master #3845 +/- ##
=======================================
Coverage 79.70% 79.70%
=======================================
Files 135 135
Lines 6158 6158
=======================================
Hits 4908 4908
Misses 1250 1250 |
Motivation/summary
This PR adds initial documentation for the OpenTelemetery collector Elastic exporter. I ended up providing a lot more detail than I expected--mostly because the official OT docs are still quite light.
I think it'd be nice to add a quick start or docker demo as an example.
Any and all feedback is welcome.
Documentation preivew
Click here to see a doc preview 🚀
Notes
I've used two different setups to play around with this integration. The first only kind of worked:
Jaeger hot rod --> Jaeger Agent --> Jaeger oltp collector --> Otel Collector --> ESS. I was able to get traces into ES, but I don't think the Otel collector liked the formatting of
http.url
from Jaeger hot rod demo.I then altered the OpenTelemetry demo app to use the zipkin sleuth webmvc example app --> Otel collector --> ESS. Super basic, but it worked nicely. You can see the dockerfile/compose/etc., here.
@cyrille-leclerc gave me access to his demo application, so I'll give that a shot tonight or tomorrow as well.
To do
Real architecture diagram instead of my text-based version
Define IDs for all headers
- [ ] Quickstart?Related issues
Closes elastic/apm#269.