Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filelog receiver #2555

Merged
merged 3 commits into from
Mar 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/otelcontribcol/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/carbonreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/collectdreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/filelogreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/jmxreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver"
Expand Down Expand Up @@ -101,6 +102,7 @@ func components() (component.Factories, error) {
carbonreceiver.NewFactory(),
collectdreceiver.NewFactory(),
dockerstatsreceiver.NewFactory(),
filelogreceiver.NewFactory(),
jmxreceiver.NewFactory(),
k8sclusterreceiver.NewFactory(),
kubeletstatsreceiver.NewFactory(),
Expand Down
6 changes: 1 addition & 5 deletions cmd/otelcontribcol/unstable_components_enabled.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,8 @@ package main

import (
"go.opentelemetry.io/collector/component"

"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/filelogreceiver"
)

func extraReceivers() []component.ReceiverFactory {
return []component.ReceiverFactory{
filelogreceiver.NewFactory(),
}
return []component.ReceiverFactory{}
}
76 changes: 76 additions & 0 deletions testbed/tests/log_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
// Copyright 2019, OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// Package tests contains test cases. To run the tests go to tests directory and run:
// RUN_TESTBED=1 go test -v

package tests

import (
"testing"

"go.opentelemetry.io/collector/testbed/testbed"
scenarios "go.opentelemetry.io/collector/testbed/tests"

"github.com/open-telemetry/opentelemetry-collector-contrib/testbed/datasenders"
)

func TestLog10kDPS(t *testing.T) {
tests := []struct {
name string
sender testbed.DataSender
receiver testbed.DataReceiver
resourceSpec testbed.ResourceSpec
extensions map[string]string
}{
{
name: "OTLP",
sender: testbed.NewOTLPLogsDataSender(testbed.DefaultHost, testbed.GetAvailablePort(t)),
receiver: testbed.NewOTLPDataReceiver(testbed.GetAvailablePort(t)),
resourceSpec: testbed.ResourceSpec{
ExpectedMaxCPU: 20,
ExpectedMaxRAM: 80,
},
},
{
name: "filelog",
sender: datasenders.NewFileLogWriter(),
receiver: testbed.NewOTLPDataReceiver(testbed.GetAvailablePort(t)),
resourceSpec: testbed.ResourceSpec{
ExpectedMaxCPU: 50,
ExpectedMaxRAM: 150,
},
},
}

processors := map[string]string{
"batch": `
batch:
`,
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
scenarios.Scenario10kItemsPerSecond(
t,
test.sender,
test.receiver,
test.resourceSpec,
contribPerfResultsSummary,
processors,
test.extensions,
)
})
}
}
55 changes: 2 additions & 53 deletions testbed/tests_unstable_exe/log_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,65 +21,14 @@ import (
"testing"

"go.opentelemetry.io/collector/testbed/testbed"
scenarios "go.opentelemetry.io/collector/testbed/tests"

"github.com/open-telemetry/opentelemetry-collector-contrib/testbed/datasenders"
)

var contribPerfResultsSummary testbed.TestResultsSummary = &testbed.PerformanceResults{}

// TestMain is used to initiate setup, execution and tear down of testbed.
func TestMain(m *testing.M) {
// These tests are using the unstable executable.
testbed.GlobalConfig.DefaultAgentExeRelativeFile = "../../bin/otelcontribcol_unstable_{{.GOOS}}_{{.GOARCH}}"
testbed.GlobalConfig.DefaultAgentExeRelativeFile = "../../bin/otelcontribcol_{{.GOOS}}_{{.GOARCH}}"
testbed.DoTestMain(m, contribPerfResultsSummary)
}

func TestLog10kDPS(t *testing.T) {
tests := []struct {
name string
sender testbed.DataSender
receiver testbed.DataReceiver
resourceSpec testbed.ResourceSpec
extensions map[string]string
}{
{
name: "OTLP",
sender: testbed.NewOTLPLogsDataSender(testbed.DefaultHost, testbed.GetAvailablePort(t)),
receiver: testbed.NewOTLPDataReceiver(testbed.GetAvailablePort(t)),
resourceSpec: testbed.ResourceSpec{
ExpectedMaxCPU: 20,
ExpectedMaxRAM: 80,
},
},
{
name: "filelog",
sender: datasenders.NewFileLogWriter(),
receiver: testbed.NewOTLPDataReceiver(testbed.GetAvailablePort(t)),
resourceSpec: testbed.ResourceSpec{
ExpectedMaxCPU: 50,
ExpectedMaxRAM: 150,
},
},
}

processors := map[string]string{
"batch": `
batch:
`,
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
scenarios.Scenario10kItemsPerSecond(
t,
test.sender,
test.receiver,
test.resourceSpec,
contribPerfResultsSummary,
processors,
test.extensions,
)
})
}
}
// This file is left with no tests as a placeholder for future unstable exe tests