Enable filelog receiver #2555
Enable filelog receiver #2555
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
+ Coverage 91.17% 91.19% +0.01%
==========================================
Files 419 419
Lines 20983 20984 +1
==========================================
+ Hits 19132 19137 +5
+ Misses 1383 1380 -3
+ Partials 468 467 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
My understanding is that we are moving filelog out of the "unstable" build, and documenting its maturity like other components. If this is correct, then I believe there are a few related items that should be considered with this change.
We also need to remove filelog from unstable_components_enabled.go.
log_tests.go should be moved to testbed/tests.
Also, you mentioned yesterday that we should enable more operators. Should we do that in this PR or another?
|
Ahh, good points @djaglowski ! I will take care of that, missed that we also have As for the other operators, the suggestion was to handle it in a separate PR |
|
BTW, wasn't sure if after becoming empty, the whole unstable exe tests should be removed or not. My feeling was it would be better to just leave it empty |
pmm-sumo
force-pushed
the
filelog-enablement
branch
from
6a131f0 to
a029677
Compare
* Enable filelog receiver * Remove filelog from unstable components * Leave empty placeholder for unstable exe tests
Description:
Enables
filelogreceiverby defaultLink to tracking Issue: One of the prerequisites for #2536
Testing: on top of existing unit tests, manually tested file logging in several scenarios (local file logging, K8s DaemonSet file logging)
Documentation: Existing documentation describes the usage already