[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

lewis262626 · 2023-03-09T18:53:04Z

Description: New AWS CloudWatch metrics receiver initial PR

Link to tracking Issue: #15667

Testing: Unit tests for component config and factory

PR supersedes: #19218

lewis262626 · 2023-03-09T18:53:46Z

cc @jpkrohling @kovrus

.github/ISSUE_TEMPLATE/feature_request.yaml

runforesight · 2023-03-09T21:51:15Z

Foresight Summary

Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

⭕ build-and-test-windows workflow has finished in 8 seconds (33 minutes 31 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 1 minute 17 seconds and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ check-links workflow has finished in 1 minute 45 seconds (⚠️ 40 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ changelog workflow has finished in 2 minutes 30 seconds and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

build-and-test workflow has finished in 24 minutes 10 seconds (25 minutes 28 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.20, connector)	N/A	✅ 126 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, connector)	N/A	✅ 126 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	N/A	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	N/A	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, internal)	N/A	✅ 583 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	N/A	✅ 544 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, extension)	N/A	✅ 544 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	N/A	✅ 583 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	N/A	✅ 1557 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, processor)	N/A	✅ 1557 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	N/A	✅ 2631 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, receiver-0)	N/A	✅ 2631 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, exporter)	N/A	✅ 2505 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	N/A	✅ 1965 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, receiver-1)	N/A	✅ 1965 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	N/A	✅ 2505 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	N/A	✅ 4756 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, other)	N/A	✅ 4756 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	N/A	✅ 55 ❌ 0 ⏭ 0 🔗	See Details

✅ prometheus-compliance-tests workflow has finished in 10 minutes 15 seconds (⚠️ 3 minutes 54 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ load-tests workflow has finished in 15 minutes 21 seconds (⚠️ 4 minutes 27 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 18 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

✅ e2e-tests workflow has finished in 17 minutes 41 seconds (⚠️ 2 minutes 50 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

Job	Failed Steps	Tests
kubernetes-test (v1.26.0)	- 🔗	N/A	See Details
kubernetes-test (v1.25.3)	- 🔗	N/A	See Details
kubernetes-test (v1.24.7)	- 🔗	N/A	See Details
kubernetes-test (v1.23.13)	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

kovrus

LGTM

receiver/awscloudwatchmetricsreceiver/config.go

lewis262626 · 2023-03-11T14:02:45Z

Unsure why CI is failing. Logs are saying it's failing on a Jaeger test 🤔

atoulme · 2023-03-11T17:45:52Z

It’s failing on checks too, please take a look

lewis262626 · 2023-03-11T18:09:07Z

@atoulme I fixed the issue with make goporto, but the jaeger issue seems to be nothing related to my commits. The logs say something is already listening on that port:

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4387063396/jobs/7685532139#step:9:520

Might have just been a random issue

atoulme · 2023-03-11T18:10:22Z

It's a flaky test: #9113

lewis262626 · 2023-03-11T18:11:06Z

It's a flaky test: #9113

Ok, hopefully a re-run fixes it

atoulme · 2023-03-12T08:43:53Z

Please add the new module to versions.yaml with Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml

lewis262626 · 2023-03-12T11:40:10Z

Please add the new module to versions.yaml with Using versioning file /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/versions.yaml

Cheers, fixed.

lewis262626 · 2023-03-14T09:18:25Z

Can someone with write permissions merge this PR please?

matej-g

Thanks for this @lewis262626!

I left a few questions / suggestions. It seems like the receiver does not implement any CloudWatch API polling yet? Is this meant to provide just bare bones for the receiver?

(Sorry if that's just my unfamiliarity with process, not sure what is the required minimum viable functionality for a receiver to be merged. I was expecting an initial version to already be capable of receiving metrics).

receiver/awscloudwatchmetricsreceiver/receiver.go

receiver/awscloudwatchmetricsreceiver/config.go

receiver/awscloudwatchmetricsreceiver/README.md

receiver/awscloudwatchmetricsreceiver/config.go

lewis262626 · 2023-03-15T16:35:24Z

Thanks for this @lewis262626!

I left a few questions / suggestions. It seems like the receiver does not implement any CloudWatch API polling yet? Is this meant to provide just bare bones for the receiver?

(Sorry if that's just my unfamiliarity with process, not sure what is the required minimum viable functionality for a receiver to be merged. I was expecting an initial version to already be capable of receiving metrics).

I was asked to split up my original PR, hence this bare bones receiver. You're more than welcome to check out and build my original
PR

matej-g · 2023-03-22T10:10:24Z

@lewis262626 thanks for the explanation, let's get this in! ❤️

atoulme · 2023-03-22T12:55:26Z

Please rebase, thanks!

codeboten

Please resolve/address the remaining comments and we can get this merged!

jpkrohling

dependabot conflict solved, but apparently, there are a few unhandled comments. I'll go over this once the comments are taken care of.

lewis262626 · 2023-03-28T06:54:20Z

@lewis262626 thanks for the explanation, let's get this in! ❤️

I have some free time later this week. Will resolve the outstanding comments and rebase

lewis262626 · 2023-04-24T15:15:54Z

Have rebased changes from main to my branch. Gonna work through the comments and hopefully get this merged soon

lewis262626 · 2023-04-24T17:05:39Z

I can add the polling logic once this PR has been merged

TylerHelmuth · 2023-04-25T20:04:42Z

@jpkrohling please give final review as the sponsor.

As per GH comment, include the number of metrics you can define in the error message. Lowercase debug messages for start and shutdown receiver method

Co-authored-by: Antoine Toulme <[email protected]>

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

lewis262626 · 2023-05-19T19:37:17Z

Should all be fixed. Appreciate a final review @jpkrohling

dmitryax · 2023-05-19T21:50:13Z

@lewis262626 please take a look at the failing linter

lewis262626 · 2023-05-19T22:14:24Z

@lewis262626 please take a look at the failing linter

Fixed the linter issue

receiver/awscloudwatchmetricsreceiver/config_test.go

lewis262626 requested review from a team and bogdandrutu March 9, 2023 18:53

github-actions bot assigned dmitryax Mar 9, 2023

atoulme reviewed Mar 9, 2023

View reviewed changes

.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved

kovrus approved these changes Mar 10, 2023

View reviewed changes

receiver/awscloudwatchmetricsreceiver/config.go Outdated Show resolved Hide resolved

atoulme added the Accepted Component New component has been sponsored label Mar 12, 2023

atoulme approved these changes Mar 13, 2023

View reviewed changes

atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 14, 2023

matej-g reviewed Mar 15, 2023

View reviewed changes

codeboten reviewed Mar 27, 2023

View reviewed changes

codeboten removed the ready to merge Code review completed; ready to merge by maintainers label Mar 27, 2023

jpkrohling reviewed Mar 27, 2023

View reviewed changes

lewis262626 force-pushed the awscloudwatchmetricsreceiver branch from 281e034 to b39cb85 Compare April 24, 2023 15:14

lewis262626 and others added 20 commits May 19, 2023 20:33

Fix(errors): Improve tooManyMetrics error message

293a1da

As per GH comment, include the number of metrics you can define in the error message. Lowercase debug messages for start and shutdown receiver method

Chore: run make goporto

693b9ad

Chore: make gendependabot

5cad29a

Chore: add module to versions.yaml

1fdfb60

chore: dp templates

98872d2

Chore: Update based on PR comments

aa01809

Chore: update tests based on PR comments

03bd2d3

fix(spelling): Fix function spelling

9c33287

Update .github/CODEOWNERS

238547b

Co-authored-by: Antoine Toulme <[email protected]>

Chore: make gendependabot

eef5d33

Chore: bump deps

45a6e80

Fix(docs): update aws cli link

c4fa0e1

Chore: make gotidy

4e8c26e

Update receiver/awscloudwatchmetricsreceiver/config_test.go

11cc285

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

Update receiver/awscloudwatchmetricsreceiver/config_test.go

27b144b

Co-authored-by: Juraci Paixão Kröhling <[email protected]>

Update receiver/awscloudwatchmetricsreceiver/config_test.go

5e367cb

chore: test formatting

0adc207

docs: delete pricing sentence

a053f52

Chore: update tests with proper examples

8bf1c6d

chore: make gendependabot

afc2113

lewis262626 force-pushed the awscloudwatchmetricsreceiver branch from 934968d to afc2113 Compare May 19, 2023 19:36

chore: make addlicense

009ff79

jpkrohling approved these changes May 22, 2023

View reviewed changes

receiver/awscloudwatchmetricsreceiver/config_test.go Show resolved Hide resolved

jpkrohling merged commit 9a9ffcd into open-telemetry:main May 22, 2023

github-actions bot added this to the next release milestone May 22, 2023

matej-g mentioned this pull request May 24, 2023

New component: AWS CloudWatch metrics receiver #15667

Open

2 tasks

lewis262626 mentioned this pull request May 25, 2023

REQUEST: New membership for lewis262626 open-telemetry/community#1510

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

lewis262626 commented Mar 9, 2023 •

edited

Loading

lewis262626 commented Mar 9, 2023

runforesight bot commented Mar 9, 2023 •

edited

Loading

⭕ build-and-test-windows workflow has finished in 8 seconds (33 minutes 31 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

✅ telemetrygen workflow has finished in 1 minute 17 seconds and finished at 27th Mar, 2023.

✅ check-links workflow has finished in 1 minute 45 seconds (⚠️ 40 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

✅ changelog workflow has finished in 2 minutes 30 seconds and finished at 27th Mar, 2023.

build-and-test workflow has finished in 24 minutes 10 seconds (25 minutes 28 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 15 seconds (⚠️ 3 minutes 54 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

✅ load-tests workflow has finished in 15 minutes 21 seconds (⚠️ 4 minutes 27 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

✅ e2e-tests workflow has finished in 17 minutes 41 seconds (⚠️ 2 minutes 50 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

kovrus left a comment

lewis262626 commented Mar 11, 2023

atoulme commented Mar 11, 2023

lewis262626 commented Mar 11, 2023 •

edited

Loading

atoulme commented Mar 11, 2023

lewis262626 commented Mar 11, 2023

atoulme commented Mar 12, 2023

lewis262626 commented Mar 12, 2023

lewis262626 commented Mar 14, 2023

matej-g left a comment

lewis262626 commented Mar 15, 2023

matej-g commented Mar 22, 2023

atoulme commented Mar 22, 2023

codeboten left a comment

jpkrohling left a comment

lewis262626 commented Mar 28, 2023

lewis262626 commented Apr 24, 2023

lewis262626 commented Apr 24, 2023 •

edited

Loading

TylerHelmuth commented Apr 25, 2023

lewis262626 commented May 19, 2023

dmitryax commented May 19, 2023

lewis262626 commented May 19, 2023

[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

Conversation

lewis262626 commented Mar 9, 2023 • edited Loading

lewis262626 commented Mar 9, 2023

runforesight bot commented Mar 9, 2023 • edited Loading

Foresight Summary

⭕ build-and-test-windows workflow has finished in 8 seconds (33 minutes 31 seconds less than main branch avg.) and finished at 27th Mar, 2023.

✅ telemetrygen workflow has finished in 1 minute 17 seconds and finished at 27th Mar, 2023.

✅ check-links workflow has finished in 1 minute 45 seconds (⚠️ 40 seconds more than main branch avg.) and finished at 27th Mar, 2023.

✅ changelog workflow has finished in 2 minutes 30 seconds and finished at 27th Mar, 2023.

build-and-test workflow has finished in 24 minutes 10 seconds (25 minutes 28 seconds less than main branch avg.) and finished at 27th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 15 seconds (⚠️ 3 minutes 54 seconds more than main branch avg.) and finished at 27th Mar, 2023.

✅ load-tests workflow has finished in 15 minutes 21 seconds (⚠️ 4 minutes 27 seconds more than main branch avg.) and finished at 27th Mar, 2023.

✅ e2e-tests workflow has finished in 17 minutes 41 seconds (⚠️ 2 minutes 50 seconds more than main branch avg.) and finished at 27th Mar, 2023.

kovrus left a comment

Choose a reason for hiding this comment

lewis262626 commented Mar 11, 2023

atoulme commented Mar 11, 2023

lewis262626 commented Mar 11, 2023 • edited Loading

atoulme commented Mar 11, 2023

lewis262626 commented Mar 11, 2023

atoulme commented Mar 12, 2023

lewis262626 commented Mar 12, 2023

lewis262626 commented Mar 14, 2023

matej-g left a comment

Choose a reason for hiding this comment

lewis262626 commented Mar 15, 2023

matej-g commented Mar 22, 2023

atoulme commented Mar 22, 2023

codeboten left a comment

Choose a reason for hiding this comment

jpkrohling left a comment

Choose a reason for hiding this comment

lewis262626 commented Mar 28, 2023

lewis262626 commented Apr 24, 2023

lewis262626 commented Apr 24, 2023 • edited Loading

TylerHelmuth commented Apr 25, 2023

lewis262626 commented May 19, 2023

dmitryax commented May 19, 2023

lewis262626 commented May 19, 2023

lewis262626 commented Mar 9, 2023 •

edited

Loading

runforesight bot commented Mar 9, 2023 •

edited

Loading

⭕ build-and-test-windows workflow has finished in 8 seconds (33 minutes 31 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

✅ check-links workflow has finished in 1 minute 45 seconds (⚠️ 40 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

build-and-test workflow has finished in 24 minutes 10 seconds (25 minutes 28 seconds less than `main` branch avg.) and finished at 27th Mar, 2023.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 15 seconds (⚠️ 3 minutes 54 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

✅ load-tests workflow has finished in 15 minutes 21 seconds (⚠️ 4 minutes 27 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

✅ e2e-tests workflow has finished in 17 minutes 41 seconds (⚠️ 2 minutes 50 seconds more than `main` branch avg.) and finished at 27th Mar, 2023.

lewis262626 commented Mar 11, 2023 •

edited

Loading

lewis262626 commented Apr 24, 2023 •

edited

Loading