[receiver/awscloudwatchmetricsreceiver] AWS CloudWatch metrics receiver #19218

lewis262626 · 2023-03-06T18:01:40Z

Description: New AWS CloudWatch metrics receiver

Link to tracking Issue: Fixes #15667

Testing: Currently only unit tests for Config struct. Intending to add unit tests and integration tests

Added import to package name and create defaultConfig function

Started receiver struct and stubbed start and shutdown methods

linux-foundation-easycla · 2023-03-06T18:01:50Z

The committers listed above are authorized under a signed CLA.

✅ login: lewis262626 / name: Lewis (6884ded, 3da464f, 93c52b4, 0d0507c, 7eb406b, 3733bd8, 612f190, ea78a45, ab9d7d5, c73718c, ed181c2, 3ae6cac, 8def7b0, 8f2be7b, 6052dd9, f285d05, 1248c68, b6c1f81, 401fb52, b8f0178)

lewis262626 · 2023-03-06T18:02:08Z

cc @jpkrohling @kovrus

runforesight · 2023-03-08T23:33:30Z

Foresight Summary

Major Impacts

build-and-test duration(22 minutes 53 seconds) has decreased 46 minutes 26 seconds compared to main branch avg(1 hour 9 minutes 19 seconds).

View More Details

⭕ build-and-test-windows workflow has finished in 10 seconds (43 minutes 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

❌ changelog workflow has finished in 50 seconds (1 minute 41 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 1 job failed.

Job	Failed Steps	Tests
changelog	Ensure ./.chloggen/*.yaml addition(s) 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ check-links workflow has finished in 1 minute 50 seconds and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

❌ build-and-test workflow has finished in 22 minutes 53 seconds (46 minutes 26 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 9 jobs failed.

Job	Failed Steps	Tests
unittest-matrix (1.19, other)	Run Unit Tests 🔗	✅ 0 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, other)	Run Unit Tests 🔗	✅ 0 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, connector)	- 🔗	✅ 98 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, receiver-1)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 253 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 67 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, internal)	- 🔗	✅ 76 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, extension)	- 🔗	✅ 67 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 470 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 41 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, connector)	- 🔗	✅ 98 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, processor)	- 🔗	✅ 416 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, exporter)	- 🔗	✅ 253 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.20, receiver-0)	- 🔗	✅ 77 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 91 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 76 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 55 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
check-collector-module-version	Check Collector Module Version 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (connector)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	Lint 🔗	N/A	See Details
check-codeowners	Check Code Owner Existence 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
checks	Porto 🔗	N/A	See Details
unittest (1.20)	Interpret result 🔗	N/A	See Details
unittest (1.19)	Interpret result 🔗	N/A	See Details
lint	Interpret result 🔗	N/A	See Details
cross-compile	- 🔗	N/A	See Details
build-package	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 10 minutes 29 seconds (⚠️ 1 minute 59 seconds more than `main` branch avg.) and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ load-tests workflow has finished in 16 minutes 17 seconds and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 18 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

✅ e2e-tests workflow has finished in 16 minutes 6 seconds and finished at 9th Mar, 2023.

Job	Failed Steps	Tests
kubernetes-test (v1.26.0)	- 🔗	N/A	See Details
kubernetes-test (v1.25.3)	- 🔗	N/A	See Details
kubernetes-test (v1.24.7)	- 🔗	N/A	See Details
kubernetes-test (v1.23.13)	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

dmitryax · 2023-03-09T00:31:52Z

@jpkrohling @kovrus PTAL as sponsors

kovrus · 2023-03-09T13:58:20Z

@lewis262626 would it be possible to split this PR into a few pull requests? We can start with the component stub, then follow up with core logic and wrap it up by adding it to the distribution.

Testing: Currently only unit tests for Config struct. Intending to add unit tests and integration tests

So it would be enough to have this kind of testing and skeleton of the component to get the first PR merged.

lewis262626 · 2023-03-09T17:48:55Z

@kovrus Ok sure, I'll close this PR and open another one with just the stub

lewis262626 added 20 commits February 12, 2023 00:30

Feat(awscloudwatchmetricsreceiver): Initial commit

6884ded

go module init

3da464f

add copyright preface

93c52b4

added validate function

0d0507c

more on validate

7eb406b

finished config

3733bd8

factory

612f190

Added import to package name

ea78a45

Added import to package name and create defaultConfig function

Stub of createMetricsReceiver func

ab9d7d5

Start on receiver

c73718c

Started receiver struct and stubbed start and shutdown methods

Start on tests for config

ed181c2

Bump deps

3ae6cac

add tests for config

8def7b0

Update README

8f2be7b

update readme

6052dd9

library tweaks

f285d05

go mod tidy

1248c68

added pollforMetrics method

b6c1f81

some more work

401fb52

draft PR

b8f0178

github-actions bot added the cmd/configschema configschema command label Mar 6, 2023

github-actions bot requested review from dmitryax, mx-psi and pmcollins March 6, 2023 18:02

lewis262626 added 4 commits March 6, 2023 23:30

fix memory issues

a3de47a

concat results

9b6dd45

chore: fix merge conflicts

81f5852

chore(docs): update readme to include troubleshooting section

f443474

Fix: Added logic for metric attributes

7b86e49

mx-psi requested review from jpkrohling and kovrus and removed request for pmcollins, mx-psi and dmitryax March 9, 2023 08:51

lewis262626 closed this Mar 9, 2023

This was referenced Mar 9, 2023

[receiver/awscloudwatchmetricsreceiver] Add new receiver #19429

Merged

New component: AWS CloudWatch metrics receiver #15667

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/awscloudwatchmetricsreceiver] AWS CloudWatch metrics receiver #19218

[receiver/awscloudwatchmetricsreceiver] AWS CloudWatch metrics receiver #19218

lewis262626 commented Mar 6, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 6, 2023 •

edited

Loading

lewis262626 commented Mar 6, 2023

runforesight bot commented Mar 8, 2023 •

edited

Loading

`build-and-test` duration(22 minutes 53 seconds) has decreased 46 minutes 26 seconds compared to main branch avg(1 hour 9 minutes 19 seconds).

⭕ build-and-test-windows workflow has finished in 10 seconds (43 minutes 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

❌ changelog workflow has finished in 50 seconds (1 minute 41 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 1 job failed.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

✅ check-links workflow has finished in 1 minute 50 seconds and finished at 9th Mar, 2023.

❌ build-and-test workflow has finished in 22 minutes 53 seconds (46 minutes 26 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 9 jobs failed.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 29 seconds (⚠️ 1 minute 59 seconds more than `main` branch avg.) and finished at 9th Mar, 2023.

✅ load-tests workflow has finished in 16 minutes 17 seconds and finished at 9th Mar, 2023.

✅ e2e-tests workflow has finished in 16 minutes 6 seconds and finished at 9th Mar, 2023.

dmitryax commented Mar 9, 2023

kovrus commented Mar 9, 2023

lewis262626 commented Mar 9, 2023

[receiver/awscloudwatchmetricsreceiver] AWS CloudWatch metrics receiver #19218

[receiver/awscloudwatchmetricsreceiver] AWS CloudWatch metrics receiver #19218

Conversation

lewis262626 commented Mar 6, 2023 • edited Loading

linux-foundation-easycla bot commented Mar 6, 2023 • edited Loading

lewis262626 commented Mar 6, 2023

runforesight bot commented Mar 8, 2023 • edited Loading

Foresight Summary

build-and-test duration(22 minutes 53 seconds) has decreased 46 minutes 26 seconds compared to main branch avg(1 hour 9 minutes 19 seconds).

⭕ build-and-test-windows workflow has finished in 10 seconds (43 minutes 38 seconds less than main branch avg.) and finished at 9th Mar, 2023.

❌ changelog workflow has finished in 50 seconds (1 minute 41 seconds less than main branch avg.) and finished at 9th Mar, 2023. 1 job failed.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 38 seconds less than main branch avg.) and finished at 9th Mar, 2023.

✅ check-links workflow has finished in 1 minute 50 seconds and finished at 9th Mar, 2023.

❌ build-and-test workflow has finished in 22 minutes 53 seconds (46 minutes 26 seconds less than main branch avg.) and finished at 9th Mar, 2023. 9 jobs failed.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 29 seconds (⚠️ 1 minute 59 seconds more than main branch avg.) and finished at 9th Mar, 2023.

✅ load-tests workflow has finished in 16 minutes 17 seconds and finished at 9th Mar, 2023.

✅ e2e-tests workflow has finished in 16 minutes 6 seconds and finished at 9th Mar, 2023.

dmitryax commented Mar 9, 2023

kovrus commented Mar 9, 2023

lewis262626 commented Mar 9, 2023

lewis262626 commented Mar 6, 2023 •

edited

Loading

linux-foundation-easycla bot commented Mar 6, 2023 •

edited

Loading

runforesight bot commented Mar 8, 2023 •

edited

Loading

`build-and-test` duration(22 minutes 53 seconds) has decreased 46 minutes 26 seconds compared to main branch avg(1 hour 9 minutes 19 seconds).

⭕ build-and-test-windows workflow has finished in 10 seconds (43 minutes 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

❌ changelog workflow has finished in 50 seconds (1 minute 41 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 1 job failed.

✅ telemetrygen workflow has finished in 1 minute 3 seconds (1 minute 38 seconds less than `main` branch avg.) and finished at 9th Mar, 2023.

❌ build-and-test workflow has finished in 22 minutes 53 seconds (46 minutes 26 seconds less than `main` branch avg.) and finished at 9th Mar, 2023. 9 jobs failed.

✅ prometheus-compliance-tests workflow has finished in 10 minutes 29 seconds (⚠️ 1 minute 59 seconds more than `main` branch avg.) and finished at 9th Mar, 2023.