Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Fix documentation generated for optional metrics #16563

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 1, 2022

In #16556, a duplicated documentation for Default metrics was generated in the Optional metrics section. This change fixes that bug.

Duplicated documentation for default metrics was generated in the Optional metrics section. This change fixes that
@dmitryax dmitryax force-pushed the mdatagen-fix-docs-for-optional-metrics branch from c98e831 to 6723125 Compare December 1, 2022 04:59
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 1, 2022
@dmitryax
Copy link
Member Author

dmitryax commented Dec 1, 2022

@djaglowski, I messed up the Optional Metrics section in my previous PR. PTAL at this fix

@djaglowski djaglowski merged commit cb48eba into open-telemetry:main Dec 1, 2022
@dmitryax dmitryax deleted the mdatagen-fix-docs-for-optional-metrics branch December 3, 2022 10:22
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…emetry#16563)

Duplicated documentation for default metrics was generated in the Optional metrics section. This change fixes that
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants