[mdatagen] Improve generated documentation #16556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmitryax
commented
Nov 30, 2022
dmitryax
commented
- Split Metrics into two sections: Default Metrics and Optional Metrics
- Split Attributes section and move attributes to the metrics where they applicable to make it clear which attributes applied to a particular metric.
- Add "Aggregation Temporality" and "Monotonic" fields to the metric table
- Add enum values to Resource attributes
dmitryax
requested review from
djaglowski,
dashpole,
codeboten and
MovieStoreGuy
as code owners
dmitryax
force-pushed
the
mdatagen-improve-generated-documentation
branch
3 times, most recently
from
9b9e3df to
4906496
Compare
- Split Metrics into two sections: Default Metrics and Optional Metrics - Split Attributes section and move attributes to the metrics where they applicable to make it clear which attributes applied to a particular metric. - Add "Aggregation Temporality" and "Monotonic" fields to the metric table - Add enum values to Resource attributes
dmitryax
force-pushed
the
mdatagen-improve-generated-documentation
branch
from
4906496 to
dfae9d7
Compare
djaglowski
approved these changes
Dec 1, 2022
|
Much improved |
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
- Split Metrics into two sections: Default Metrics and Optional Metrics - Split Attributes section and move attributes to the metrics where they applicable to make it clear which attributes applied to a particular metric. - Add "Aggregation Temporality" and "Monotonic" fields to the metric table - Add enum values to Resource attributes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.