Support node attributes in Honeycomb exporter #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnova-etsy
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
subnova-etsy
force-pushed
the
honeycomb-node-attr
branch
from
4b0c1dd to
8822103
Compare
|
@paulosman @lizthegrey could you ptal? |
LGTM. |
lizthegrey
approved these changes
Mar 30, 2020
|
@subnova-etsy could you please rebase it? |
subnova-etsy
force-pushed
the
honeycomb-node-attr
branch
from
33cf4e1 to
01a8bd4
Compare
subnova-etsy
force-pushed
the
honeycomb-node-attr
branch
from
01a8bd4 to
02caa9a
Compare
pjanotti
approved these changes
Mar 31, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* add batch span processor. * add blocking support. * use With* function for options. - also changed how Shutdown is handled. * block Shutdown until queue is flushed. * fix comment.
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* Add gosec workflow * Update changelog * Update CHANGELOG.md Co-authored-by: Daniel Jaglowski <[email protected]> * Add trigger on PR * test Co-authored-by: Daniel Jaglowski <[email protected]>
bjrara
pushed a commit
to bjrara/opentelemetry-collector-contrib
that referenced
this pull request
Apr 3, 2024
… commits (open-telemetry#168) Add support for Container Insights on Windows for EKS * Add kubelet summary API for Windows (open-telemetry#142) * CPU extractors with unit tests (open-telemetry#146) * Add memory extractors for pod and node level (open-telemetry#147) * Define structs for CPU and Memory stats (open-telemetry#149) * Add Container level metrics for CPU and memory resources. (open-telemetry#150) * Add storage metrics for container and node level (open-telemetry#151) * Add network metrics (open-telemetry#152) * Enable awscontainerinsights receiver to run inside Host Process container (open-telemetry#153) * Add HCS shim api as alternative source for metric provider (open-telemetry#154) * Add check for host process container before reading from hcshim (open-telemetry#156) * Fix CPU utilization percentage for Windows nodes (open-telemetry#161) * Add List of Metrics for Windows + Design (open-telemetry#166) * fix fstype (open-telemetry#164)
bjrara
pushed a commit
to bjrara/opentelemetry-collector-contrib
that referenced
this pull request
Apr 3, 2024
* Add kubelet summary API for Windows (open-telemetry#142) * CPU extractors with unit tests (open-telemetry#146) * Add memory extractors for pod and node level (open-telemetry#147) * Define structs for CPU and Memory stats (open-telemetry#149) * Add Container level metrics for CPU and memory resources. (open-telemetry#150) * Add storage metrics for container and node level (open-telemetry#151) * Add network metrics (open-telemetry#152) * Enable awscontainerinsights receiver to run inside Host Process container (open-telemetry#153) * Add HCS shim api as alternative source for metric provider (open-telemetry#154) * Add check for host process container before reading from hcshim (open-telemetry#156) * Fix CPU utilization percentage for Windows nodes (open-telemetry#161) * Add List of Metrics for Windows + Design (open-telemetry#166) * fix fstype (open-telemetry#164) * Add windows build tag to fix building cw agent on Windows * Downgrade internal/aws/containerinsight from 0.92 0.89 * Separate unit tests in util.go specific for Windows * Fix util unit tests applicable for Windows * Fix goporto issue * Fix lint issue * Fix regression in unit tests caused due to rebasing mainline * Add unit tests for k8s Windows * Add unit test for kubelet client on Windows * Run DCGM scrapper only for CW agent on Linux * Separate out node Volume unit tests for Windows * Add changelog for Container Insights on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for adding Node attributes to spans sent to Honeycomb if the span is either the root span of the trace or has a remote parent (which means that the node information is likely to be different from the previous span in the trace).
Testing:
Added a test case for the Honeycomb exporter that uses a mock HttpServer to grab the output being sent to Honeycomb - this is several levels of abstraction from the code under test (the otel collector exporter calls the otel go exporter which calls libhoney to actually send the data) but could not identify a better way given the interface provided.
The test case has both a root span and a span with a remote parent which is unrealistic within a single call to the exporter but demonstrates that the attributes are included in both scenarios whilst the intermediate span show that the attributes are not added to every span in the trace.