use go1.14, mirroring main -collector repo. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizthegrey
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
pjanotti
approved these changes
Mar 26, 2020
| @@ -1,6 +1,6 @@ | |||
| module github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsxrayexporter | |||
|
|
|||
| go 1.12 | |||
| go 1.14 | |||
There was a problem hiding this comment.
hum every time we update we have to change those, I'm thinking that a better practice for this repo will be to remove the version from the module.
There was a problem hiding this comment.
we can do it separately to not confuse things
There was a problem hiding this comment.
+1 to do it separately. My understanding though is if you don't add it, go mod tidy will.
There was a problem hiding this comment.
I'm not entirely sure but I think we don't strictly need to keep updating this. This sort of refers to the minimum Go version that can build this project and AFAIK, the compiler does not enforce anything using this directive. AFAIK, it is only used to provide extra information/hints to users when a build fails.
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
bjrara
pushed a commit
to bjrara/opentelemetry-collector-contrib
that referenced
this pull request
Apr 3, 2024
… commits (open-telemetry#168) Add support for Container Insights on Windows for EKS * Add kubelet summary API for Windows (open-telemetry#142) * CPU extractors with unit tests (open-telemetry#146) * Add memory extractors for pod and node level (open-telemetry#147) * Define structs for CPU and Memory stats (open-telemetry#149) * Add Container level metrics for CPU and memory resources. (open-telemetry#150) * Add storage metrics for container and node level (open-telemetry#151) * Add network metrics (open-telemetry#152) * Enable awscontainerinsights receiver to run inside Host Process container (open-telemetry#153) * Add HCS shim api as alternative source for metric provider (open-telemetry#154) * Add check for host process container before reading from hcshim (open-telemetry#156) * Fix CPU utilization percentage for Windows nodes (open-telemetry#161) * Add List of Metrics for Windows + Design (open-telemetry#166) * fix fstype (open-telemetry#164)
bjrara
pushed a commit
to bjrara/opentelemetry-collector-contrib
that referenced
this pull request
Apr 3, 2024
* Add kubelet summary API for Windows (open-telemetry#142) * CPU extractors with unit tests (open-telemetry#146) * Add memory extractors for pod and node level (open-telemetry#147) * Define structs for CPU and Memory stats (open-telemetry#149) * Add Container level metrics for CPU and memory resources. (open-telemetry#150) * Add storage metrics for container and node level (open-telemetry#151) * Add network metrics (open-telemetry#152) * Enable awscontainerinsights receiver to run inside Host Process container (open-telemetry#153) * Add HCS shim api as alternative source for metric provider (open-telemetry#154) * Add check for host process container before reading from hcshim (open-telemetry#156) * Fix CPU utilization percentage for Windows nodes (open-telemetry#161) * Add List of Metrics for Windows + Design (open-telemetry#166) * fix fstype (open-telemetry#164) * Add windows build tag to fix building cw agent on Windows * Downgrade internal/aws/containerinsight from 0.92 0.89 * Separate unit tests in util.go specific for Windows * Fix util unit tests applicable for Windows * Fix goporto issue * Fix lint issue * Fix regression in unit tests caused due to rebasing mainline * Add unit tests for k8s Windows * Add unit test for kubelet client on Windows * Run DCGM scrapper only for CW agent on Linux * Separate out node Volume unit tests for Windows * Add changelog for Container Insights on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates to go1.14 and circleci's cimg images.
Link to tracking Issue:
open-telemetry/opentelemetry-collector#661
Testing:
CircleCI should have us covered here.
Documentation:
No docs needed.