Make + CircleCI for Code Generation (#1433) #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested changes
Nov 5, 2020
go.sum
Outdated
Comment on lines
458
to
462
| github.com/go-playground/locales v0.13.0 h1:HyWk6mgj5qFqCT5fjGBuRArbVDfE4hi8+e8ceBS/t7Q= | ||
| github.com/go-playground/locales v0.13.0/go.mod h1:taPMhCMXrRLJO55olJkUXHZBHCxTMfnGwq/HNwmWNS8= | ||
| github.com/go-playground/universal-translator v0.17.0 h1:icxd5fm+REJzpZx7ZfpaD876Lmtgy7VtROAbHHXk8no= | ||
| github.com/go-playground/universal-translator v0.17.0/go.mod h1:UkSxE5sNxxRwHyU+Scu5vgOQjsIJAF8j9muTVoKLVtA= | ||
| github.com/go-playground/validator/v10 v10.4.0 h1:72qIR/m8ybvL8L5TIyfgrigqkrw7kVYAvjEvpT85l70= | ||
| github.com/go-playground/validator/v10 v10.4.0/go.mod h1:nlOn6nFhuKACm19sB/8EGNn9GlaMV7XkbRSipzJ0Ii4= |
There was a problem hiding this comment.
This is the problem, please run go mod tidy and they will be removed
There was a problem hiding this comment.
So running make generate should not generate changes in go.sum if you just run go mod tidy
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
==========================================
+ Coverage 88.68% 88.69% +0.01%
==========================================
Files 344 344
Lines 16918 16918
==========================================
+ Hits 15003 15006 +3
+ Misses 1446 1443 -3
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Nov 5, 2020
.circleci/config.yml
Outdated
| name: Codegen | ||
| command: | | ||
| make generate | ||
| go mod tidy |
There was a problem hiding this comment.
This probably better to move it in the make rule
This adds a make target 'generate' that runs 'go generate' for all modules. It also adds a circle CI check under 'lint' that makes sure the generated modules are up to date.
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Reverse order of attribute precedence when merging two Resources This reflects a change in the specification itself. open-telemetry/opentelemetry-specification#1345 * Resolves #1500 Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a make target 'generate' that runs 'go generate' for all
modules.
It also adds a circle CI check under 'lint' that makes sure the
generated modules are up to date.