Make + CircleCI for Code Generation #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcamp
reviewed
Oct 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
+ Coverage 87.43% 88.80% +1.37%
==========================================
Files 340 341 +1
Lines 16602 16678 +76
==========================================
+ Hits 14516 14811 +295
+ Misses 1631 1402 -229
- Partials 455 465 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This adds a make target 'generate' that runs 'go generate' for all modules. It also adds a circle CI check under 'lint' that makes sure the generated modules are up to date.
jrcamp
approved these changes
Oct 30, 2020
bogdandrutu
approved these changes
Oct 30, 2020
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 1, 2020
This reverts commit 4a91354.
bogdandrutu
added a commit
that referenced
this pull request
Nov 1, 2020
Closed
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 6, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.33.0 to 1.34.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.33.0...v1.34.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a make target 'generate' that runs 'go generate' for all
modules.
It also adds a circle CI check under 'lint' that makes sure the
generated modules are up to date.