[chore] Change receiver config tests to unmarshal config only for that component. (part4) #14562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovrus
changed the title
kovrus
force-pushed
the
issue-13224/receiver-4
branch
from
a781a6f to
98ce7eb
Compare
Merged
11 tasks
|
This appears to contain many of the same changes as part 3 (memcached -> postgresql). |
let me check, I might have messed smth up while splitting a big PR |
kovrus
force-pushed
the
issue-13224/receiver-4
branch
from
98ce7eb to
78aa114
Compare
…t component. (part4) - [x] pulsarreceiver - [x] rabbitmqreceiver - [x] redisreceiver - [x] riakreceiver - [x] saphanareceiver - [x] sapmreceiver - [x] signalfxreceiver - [x] simpleprometheusreceiver - [x] skywalkingreceiver - [x] solacereceiver
kovrus
force-pushed
the
issue-13224/receiver-4
branch
from
78aa114 to
d7a6128
Compare
|
dropped |
|
I should have been more clear, but I meant to point out the whole range of receivers between memcached and postgresql, everything before pulsar. Really it doesn't matter that much but it'll allow for quicker approval and avoid a rebase. |
…for that component. (part4)
|
ah.. @djaglowski dropped the whole range. |
djaglowski
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change receivers config tests to unmarshal config only for that component.
Link to tracking Issue:
#13224