[chore] Change receiver config tests to unmarshal config only for that component. (Part 2) #14476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovrus
force-pushed
the
issue-13224/receiver
branch
3 times, most recently
from
9581cfc to
1ab12c7
Compare
kovrus
requested review from
dashpole,
djaglowski,
jmacd and
dmitryax
as code owners
kovrus
force-pushed
the
issue-13224/receiver
branch
4 times, most recently
from
5ef35cf to
1db4f14
Compare
jpkrohling
previously approved these changes
Sep 27, 2022
jpkrohling
reviewed
Sep 27, 2022
| @@ -1,15 +0,0 @@ | |||
| receivers: | |||
There was a problem hiding this comment.
Can you confirm the removal of those files are intended?
There was a problem hiding this comment.
jpkrohling
dismissed
their stale review
need to confirm the intent to remove config files
|
I would like to help with reviewing it but it's huge :) Any chance it can be broken down into smaller PRs, like 5 of them? |
kovrus
force-pushed
the
issue-13224/receiver
branch
2 times, most recently
from
b4b6e59 to
16f78e6
Compare
…t component. (part2) - [x] hostmetricsreceiver - [x] iisreceiver - [x] influxdbreceiver - [x] jmxreceiver - [x] journaldreceiver - [x] k8sclusterreceiver - [x] k8seventsreceiver - [x] kafkametricsreceiver - [x] kafkareceiver - [x] kubeletstatsreceiver - [x] prometheusexecreceiver
kovrus
force-pushed
the
issue-13224/receiver
branch
from
16f78e6 to
9fe6d67
Compare
djaglowski
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change receivers config tests to unmarshal config only for that component.
Part 1 - #13383
Link to tracking Issue:
#13224