Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/googlemanagedprometheusexporter] Add resource_to_telemetry_conversion feature #13616

Closed
wants to merge 2 commits into from
Closed

[exporter/googlemanagedprometheusexporter] Add resource_to_telemetry_conversion feature #13616

wants to merge 2 commits into from

Conversation

olekgo
Copy link

@olekgo olekgo commented Aug 25, 2022

Adds resource_to_telemetry_conversion feature that allows for converting resource attributes to telemetry attributes

Resolves: #12175

@olekgo
implement resource_to_telemetry_conversion
1bf85c4 
for googlemanagedprometheusexporter
@olekgo olekgo requested a review from a team August 25, 2022 00:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 25, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: olekgo / name: Oleksandr Gorokhovskyi (1bf85c4)

@bogdandrutu
Copy link
Member

Tests seem to fail

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 9, 2022
@dashpole dashpole added exporter/googlemanagedprometheus Google Managed Prometheus exporter enhancement New feature or request labels Sep 9, 2022
@github-actions github-actions bot removed the Stale label Sep 10, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 25, 2022
@bogdandrutu
Copy link
Member

Ping, someone needs to fix tests here.

@github-actions github-actions bot removed the Stale label Sep 30, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 15, 2022
codeboten
codeboten reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as this PR has been marked stale since october. Please re-open if necessary.

@codeboten codeboten closed this Mar 2, 2023
@algchoo algchoo mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@dashpole dashpole dashpole approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@punya punya Awaiting requested review from punya

Assignees

@dashpole dashpole

Labels
enhancement New feature or request exporter/googlemanagedprometheus Google Managed Prometheus exporter Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[googlemanagedprometheusexporter] Include resource labels
4 participants
@olekgo @bogdandrutu @codeboten @dashpole