Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMP Exporter: Retain all resource labels #21654

Closed
algchoo opened this issue May 8, 2023 · 4 comments · Fixed by #24392
Closed

GMP Exporter: Retain all resource labels #21654

algchoo opened this issue May 8, 2023 · 4 comments · Fixed by #24392
Labels
enhancement New feature or request exporter/googlemanagedprometheus Google Managed Prometheus exporter

Comments

@algchoo
Copy link

algchoo commented May 8, 2023

Component(s)

exporter/googlemanagedprometheus

Is your feature request related to a problem? Please describe.

The problem is that this exporter just drops important information attached to resource labels. If the resource labels don't align with what is documented here they are dropped.

Describe the solution you'd like

Ideally, it'd be handled the same way it's handled in the following exporters:

I see an issue exists here, but also that the associated PR has been closed, for now.

Describe alternatives you've considered

No response

Additional context

No response

@algchoo algchoo added enhancement New feature or request needs triage New item requiring triage labels May 8, 2023
@github-actions github-actions bot added the exporter/googlemanagedprometheus Google Managed Prometheus exporter label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label May 8, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 10, 2023
@damemi
Copy link
Contributor

damemi commented Jul 10, 2023

The cloud monitoring exporter has resource_filters, which does what you're asking (though the attributes are added as metric labels, not monitored resource labels). I don't know if there's a reason we couldn't do that for GMP as well

@damemi
Copy link
Contributor

damemi commented Jul 19, 2023

Opened #24392 which would allow resource_filters to be set on the GMP exporter. For the purpose of this issue, all resource labels could be copied using a regex that matches everythign.

codeboten pushed a commit that referenced this issue Jul 21, 2023
Fixes #21654 

Allows GMP exporter to use the same `resource_filters` option as
supported by the main GCP exporter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/googlemanagedprometheus Google Managed Prometheus exporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants